Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In ncx, TOC section scope not included in the parent - no warning or error #175

Open
rdeltour opened this issue Oct 15, 2013 · 12 comments
Open
Labels
priority: low To be processed when time allows status: accepted Ready to be further processed type: feature The issue describes a new feature request

Comments

@rdeltour
Copy link
Member

From vgros00@gmail.com on May 07, 2012 16:43:07

PROBLEM: In toc.ncx, when a TOC section scope (src attribute) is not included in the parent, there is no epubcheck warning or error.

METHOD: for example :

  <navMap>
    <navPoint id="chapter" playOrder="1">
      <navLabel>
        <text>Chapter 1</text>
      </navLabel>
      <content src="chapter.html#first"/>
      <navPoint id="section" playOrder="2">
        <navLabel>
          <text>Section 1</text>
        </navLabel>
        <content src="chapter.html"/>
      </navPoint>
    </navPoint>
  </navMap>

RESULT: No warning or error in epubcheck3.0b5.

EXPECTED: If there is a subsection included in the parent, but src attribute not included in the src parent ==> warning (or error).

PLATFORM: windows 7

Original issue: http://code.google.com/p/epubcheck/issues/detail?id=175

@rdeltour
Copy link
Member Author

From markus.g...@gmail.com on October 11, 2012 14:11:42

Status: Accepted
Labels: Type-Enhancement Priority-Low EPUBVersion-ALL

@jschvartz jschvartz mentioned this issue Mar 26, 2014
@jschvartz
Copy link

Had the same problem. Kindle refuses to convert ....

@tofi86
Copy link
Collaborator

tofi86 commented Mar 26, 2014

I'm going to schedule this for next epubcheck maintenance release...

@tofi86 tofi86 added this to the 3.0.2 milestone Mar 26, 2014
@jschvartz
Copy link

Thanks Tobias.
Is there an open discussion about checks not purely "Epub compliance", but rather "Device compliance". The goal would be to issue warnings concerning specific devices like:

  • images more than 2 million pixels for Ibook
  • specific constraints for Kindle
    etc..
    Or is this too far beyond the scope of EpubCheck ?
    Joel

@tofi86
Copy link
Collaborator

tofi86 commented Mar 30, 2014

With epubcheck 3.0.1 we introduced "HINTS" for exactly this purpose.
However, the HINTS implemented so far are only a few and not device/vendor specific. I think I remember a discussion about not implementing vendor specific HINTS since they are hard to maintain...

@rdeltour rdeltour removed this from the 3.0.2 milestone Aug 15, 2014
@rdeltour rdeltour added review and removed review labels Aug 15, 2014
@DLSieving
Copy link

Here we are in late 2016 and the problem has not been fixed.

20160928 eb2 kprev toc errors

20160928 eb2 kprev version info

@DLSieving
Copy link

This error occurred for me in one case because the chapters in the body of the book were not in the same order as they were referenced in my custom TOC. Even though I had deselected all TOC auto generation options in Calibre, Kindle Previewer went ahead notwithstanding and attempted to construct its own internal TOC. Finding chapters out of their listed order during this process apparently confused it.

@jimrose38
Copy link

This error also occurred when I attempted to upload a Calibre epub file to kdp. The problem was that I had two navPoints titled the same "Epilogue" Not sure how that happened. Was able to delete the first navPoint using Calibre, and the Kindle previewer was happy.

@othmanemoujahid
Copy link

othmanemoujahid commented Jul 8, 2017

To resolve that, should change the type of toc from empty to normal

example

@tofi86 tofi86 added type: feature The issue describes a new feature request and removed type: improvement The issue suggests an improvement of an existing feature labels Jul 8, 2017
@rdeltour rdeltour removed the imported label Nov 12, 2018
@rdeltour rdeltour added status: accepted Ready to be further processed and removed status: needs review Needs to be reviewed by a team member before further processing labels Feb 26, 2019
@rdeltour
Copy link
Member Author

rdeltour commented Feb 26, 2019

The feature request sounds legit (ping @danielweck @mattgarrish), although given this affect EPUB 2.0.1 this is low priority.

Please upvote this issue (in the opening comment) if you feel it should be prioritized.

@rdeltour rdeltour added the priority: low To be processed when time allows label Feb 26, 2019
@rdeltour
Copy link
Member Author

@vincent-gros I'm not sure if your 👍 is related to the treatment of the issue, or actually an upvote 🤔. For upvoting, please 👍 on the first issue comment! Sorry to not have made this clearer 😊

@vincent-gros
Copy link
Contributor

vincent-gros commented Feb 26, 2019

Both! I will upvote on the first comment, because this can detect a blocker for converting or ingesting EPUB2 in some softwares/platforms. But I also agree with you, this is not high priority because mainly related on EPUB 2.0.1.

(note: I am vgros00@gmail.com, the author of this issue 😄)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: low To be processed when time allows status: accepted Ready to be further processed type: feature The issue describes a new feature request
Projects
None yet
Development

No branches or pull requests

7 participants