Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

valid test files in 'invalid' folder and vice versa #659

Closed
tofi86 opened this issue Dec 5, 2015 · 5 comments
Closed

valid test files in 'invalid' folder and vice versa #659

tofi86 opened this issue Dec 5, 2015 · 5 comments
Assignees
@tofi86
Labels
status: has PR The issue is being processed in a pull request
Milestone
4.1.0

Comments

@tofi86
Copy link
Collaborator

tofi86 commented Dec 5, 2015 •
edited

The test file src/test/resources/30/epub/invalid/issue265.epub in folder invalid is valid.
Tests depending on this epub may need to be changed.

Edit: Done
@tofi86
Copy link
Collaborator Author

tofi86 commented Dec 5, 2015 •
edited

same for src/test/resources/30/epub/invalid/edupub-toc-missing-branches.epub

Edit: deferred (see note below)

@tofi86 tofi86 changed the title test file 'issue265.epub' in invalid folder is valid valid test files in 'invalid' folder and vice versa Dec 5, 2015
@tofi86
Copy link
Collaborator Author

tofi86 commented Dec 5, 2015 •
edited

/src/test/resources/30/epub/valid/extension-1.ePub in folder 'valid' is invalid.

Edit: Done

@tofi86
Copy link
Collaborator Author

tofi86 commented Dec 5, 2015 •
edited

/src/test/resources/30/epub/valid/valid ncx.epub in folder 'valid' is invalid.

Edit: Done

@tofi86
Copy link
Collaborator Author

tofi86 commented Dec 5, 2015 •
edited

/src/test/resources/20/epub/valid/issue194.bad.epub in folder 'valid' is invalid.

Edit: Done

@tofi86 tofi86 self-assigned this Dec 22, 2016
@tofi86 tofi86 added this to the Next milestone Dec 22, 2016
This was referenced Dec 23, 2016
Closed
Closed
tofi86 added a commit that referenced this issue Dec 24, 2016
@tofi86
remove css absolute position from font obfuscation test epub
a914047 
the absolute css position should not be part of the font obfuscation test

refs #659
tofi86 added a commit that referenced this issue Dec 24, 2016
@tofi86
move extension test epub from valid to invalid because of PKG_016
bf70931 
refs #659
tofi86 added a commit that referenced this issue Dec 24, 2016
@tofi86
fix test „valid-ncx.epub“ and add to test suite
148f334 
XML in OPF was:
    <spine toc="ncx">>
corrected to
    <spine toc="ncx">

which triggered RSC_005 but test case was about valid NCX structure

also, there was no unit test for this file so I added a new one

refs #659
tofi86 added a commit that referenced this issue Dec 24, 2016
@tofi86
move invalid testfile „issue194 .bad.epub“ to invalid folder
e819dde 
refs #659
@tofi86 tofi86 mentioned this issue Dec 24, 2016
Closed
@tofi86
Copy link
Collaborator Author

tofi86 commented Dec 28, 2016

same for src/test/resources/30/epub/invalid/edupub-toc-missing-branches.epub

This is valid now because severity of NAV_004 was lowered by @rdeltour with f9c5d6e (see #507). Once #507 is closed, the file is invalid again and in right place...
Until then, I won't move it around...

@tofi86 tofi86 added the status: has PR The issue is being processed in a pull request label Dec 28, 2016
rdeltour pushed a commit that referenced this issue Jun 12, 2017
@tofi86 @rdeltour
remove css absolute position from font obfuscation test epub
44312b9 
the absolute css position should not be part of the font obfuscation test

refs #659
rdeltour pushed a commit that referenced this issue Jun 12, 2017
@tofi86 @rdeltour
move extension test epub from valid to invalid because of PKG_016
ba09e29 
refs #659
rdeltour pushed a commit that referenced this issue Jun 12, 2017
@tofi86 @rdeltour
fix test „valid-ncx.epub“ and add to test suite
4f7f592 
XML in OPF was:
    <spine toc="ncx">>
corrected to
    <spine toc="ncx">

which triggered RSC_005 but test case was about valid NCX structure

also, there was no unit test for this file so I added a new one

refs #659
rdeltour pushed a commit that referenced this issue Jun 12, 2017
@tofi86 @rdeltour
move invalid testfile „issue194 .bad.epub“ to invalid folder
72cd6aa 
refs #659
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tofi86 tofi86

Labels
status: has PR The issue is being processed in a pull request
Projects
None yet
Milestone
4.1.0
Development

No branches or pull requests
1 participant
@tofi86