feat: check file name uniqueness with Unicode canonical case fold normalization #1409
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…malization This commit changes the OCF container file name uniqueness check to perform the Unicode canonical case fold normalization step defined in https://www.w3.org/TR/charmod-norm/#CanonicalFoldNormalizationStep That is, we normalize the file name to NFD then apply full case folding before checking for uniqueness. Previously the behaviors was: - we checked for uniqueness of the lower case form (String.toLowerCase) - we checked for uniqueness of the NFC-normalized lower case This was flawed, since String.toLowerCase is not equivalent to Unicode full case folding. Also, previously, only a warning (OPF-061) was reported when names were not unique after NFC normalization. This is now an error, using the same code as the other uniqueness failures (OPF-060). This commit removes OPF-061, which is no longer used. Fixes #1246
mattgarrish
approved these changes
Dec 2, 2022
Base automatically changed from
feat/ocf-filename-character-check
to
release/v5.0.0
December 6, 2022 12:13
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit changes the OCF container file name uniqueness check to perform the Unicode canonical case fold normalization step defined in https://www.w3.org/TR/charmod-norm/#CanonicalFoldNormalizationStep
That is, we normalize the file name to NFD then apply full case folding before checking for uniqueness.
Previously the behaviors was:
This was flawed, since String.toLowerCase is not equivalent to Unicode full case folding.
Also, previously, only a warning (OPF-061) was reported when names were not unique after NFC normalization. This is now an error, using the same code as the other uniqueness failures (OPF-060).
This commit removes OPF-061, which is no longer used.
Fixes #1246