feat: new requirements of package link 'media-type' attribute #1423
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit implements the new requirements of the `media-type` attribute of the package document `link` element. - new `OPF-093` error is reported when the `media-type` attribute is missing on linked resources located inside the EPUB container - new `OPF-094` error is reported when the `media-type` attribute is missing on a link where the `rel` keyword requires it (this was previously checked with Schematron) - new `OPF-095` error is reported when the media type of a "voicing" linked resource is not an audio type (this was previously checked with Schematron) These new checks are implemented in Java, and the old schematron logic is removed. Fixes #1307
mattgarrish
approved these changes
Dec 5, 2022
Base automatically changed from
fix/default-vocab-prefix-error
to
release/v5.0.0
December 6, 2022 14:41
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit implements the new requirements of the
media-typeattribute of the package documentlinkelement.OPF-093error is reported when themedia-typeattribute is missing on linked resources located inside the EPUB containerOPF-094error is reported when themedia-typeattribute is missing on a link where therelkeyword requires it (this was previously checked with Schematron)OPF-095error is reported when the media type of a "voicing" linked resource is not an audio type (this was previously checked with Schematron)These new checks are implemented in Java, and the old schematron logic is removed.
Fixes #1307