Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix a variety of JSON report issues #1525

Merged
merged 7 commits into from
Jul 7, 2023
Merged

Fix a variety of JSON report issues #1525

merged 7 commits into from
Jul 7, 2023

Commits on Jul 6, 2023

  1. test: add a step to check values in a list

    @rdeltour
    rdeltour committed Jul 6, 2023
    Configuration menu
    Copy the full SHA
    65828c2 View commit details
    Browse the repository at this point in the history

  2. fix: remove undefined isHTML5 field from the JSON report 

    See #1515
    @rdeltour
    rdeltour committed Jul 6, 2023
    Configuration menu
    Copy the full SHA
    00b1d20 View commit details
    Browse the repository at this point in the history

  3. fix: remove undefined script-related fields from the JSON report 

    This commit remove the following properties from the JSON report, as these were no longer set by EPUBCheck:
- `scriptSrc`
- `scriptTag`
- `scriptInline`

The report now on says if an item is scripted or not.

See #1515
    @rdeltour
    rdeltour committed Jul 6, 2023
    Configuration menu
    Copy the full SHA
    1931d73 View commit details
    Browse the repository at this point in the history

  4. fix: remove undefined navigationOrder field from the JSON report 

    This commit remove the `navigationOrder` field from the JSON report, as this was no longer set by EPUBCheck.

Navigation order consistency is better checked manually or with help of external tools.

See #1515
    @rdeltour
    rdeltour committed Jul 6, 2023
    Configuration menu
    Copy the full SHA
    39234a6 View commit details
    Browse the repository at this point in the history

  5. fix: properly set the rendition fields in the JSON report 

    See #1515
    @rdeltour
    rdeltour committed Jul 6, 2023
    Configuration menu
    Copy the full SHA
    da643e4 View commit details
    Browse the repository at this point in the history

  6. fix: properly set the referencedItems field in the JSON report 

    See #1515
    @rdeltour
    rdeltour committed Jul 6, 2023
    Configuration menu
    Copy the full SHA
    7804c78 View commit details
    Browse the repository at this point in the history

  7. fix: properly set font fields in the JSON report 

    All fonts were added to the `refFonts` field, even when embedded. This commit fixes that.

See #1515
Fix #1519
    @rdeltour
    rdeltour committed Jul 6, 2023
    Configuration menu
    Copy the full SHA
    8575a6b View commit details
    Browse the repository at this point in the history