-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
InteractionID & Count Explainer #133
Conversation
I like the latest explainer. I made some updates directly to your readme. I tried to submit as a PR so you can see a nice diff, but there was an error and I was able to just push a change directly into your branch. You can see the diff. LGTM! |
Here is the line that is breaking the build: 7fa8ac5 Indeed, it seems to have a missing attribute value. I will file a separate spec issue. |
@mmocny The updates looks great! And thanks for digging into the build issue. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with the one remaining comment at the bottom, to update the code snippet just a bit.
I merged this in, but it didn't automatically squash the commits. I'm so accustomed to this being the default option, that I forgot to look for it. (It just means we have a few extra commits in git history, I wouldn't bother re-writting main branch to fix this). I think we can change this in the github project settings for next time. |
Hmm, I don't have access to settings for the repo, and it may even be explicitly disabled as an option for merge... Some docs references: |
Add an explainer for interactionId & Count.