Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[geometry] Structured serialization should branch on is 2D #161

Closed
zcorpan opened this issue May 15, 2017 · 1 comment
Closed

[geometry] Structured serialization should branch on is 2D #161

zcorpan opened this issue May 15, 2017 · 1 comment
Assignees
@zcorpan
Labels
geometry-1

Comments

@zcorpan
Copy link
Member

zcorpan commented May 15, 2017

See https://codereview.chromium.org/2874203003/#msg8

Consider this test:
http://software.hixie.ch/utilities/js/live-dom-viewer/saved/5171

<!DOCTYPE html>
<script>
onmessage = (e) => w(1 / e.data.m13);
var m = new DOMMatrix();
m.m13 = -0;
w(m.is2D);
postMessage(m, '*');
</script>

Per current spec this should log

log: true
log: -Infinity

But the Chromium CL it would say Infinity, I believe, since it only copies a-f for a 2d matrix. I think that is very reasonable, so suggest we change the spec.

cc @domenic @fserb
zcorpan added a commit that referenced this issue May 16, 2017
@zcorpan
[geometry] Do not structured serialize -0 for m13 of a 2d matrix
c94355b 
Fixes #161.
@zcorpan zcorpan mentioned this issue May 16, 2017
Merged
zcorpan added a commit that referenced this issue May 16, 2017
@zcorpan
[geometry] Do not structured serialize -0 for m13 of a 2d matrix
6ab7452 
Fixes #161.

Tests: web-platform-tests/wpt#5937
@zcorpan
Copy link
Member Author

zcorpan commented May 16, 2017

Spec PR: #162
WPT PR: web-platform-tests/wpt#5937

zcorpan added a commit that referenced this issue May 18, 2017
@zcorpan
[geometry] Do not structured serialize -0 for m13 of a 2d matrix
bc125de 
Fixes #161.

Tests: web-platform-tests/wpt#5937
@tabatkins tabatkins removed the ready label May 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zcorpan zcorpan

Labels
geometry-1
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@zcorpan @tabatkins