Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[css-masking-1] The syntax of mask shorthand should use <coord-box> instead of <geometry-box> #551

Open
BorisChiou opened this issue Mar 1, 2024 · 1 comment

Comments

@BorisChiou
Copy link

Per current ED spec, the syntax of <mask-layer> of mask shorthand property still uses <geometry-box>:

<mask-layer> =
 <mask-reference> ||
 <position> [ / <bg-size> ]? ||
 <repeat-style> ||
 <geometry-box> ||
 [ <geometry-box> | no-clip ] ||
 <compositing-operator> ||
 <masking-mode>

However, it's not correct because both mask-origin and mask-clip use <coord-box>, which doesn't include <margin-box>, for example. We probably forgot to update the syntax of mask shorthand when migrating <coord-box> into mask-origin and mask-clip.

BorisChiou added a commit to BorisChiou/fxtf-drafts that referenced this issue Mar 1, 2024
…thand property.

`mask-origin` and `mask-clip` use `<coord-box>`, and for consistency,
the syntax and description of `mask` shorthand should use `<coord-box>`
for these two components.

Issue: w3c#551
@BorisChiou
Copy link
Author

I uploaded a PR for this: #552.

If this is an obvious spec issue and we agree with this, we probably can just merge this PR.

BorisChiou added a commit to BorisChiou/fxtf-drafts that referenced this issue Mar 1, 2024
…thand property.

`mask-origin` and `mask-clip` use `<coord-box>`, and for consistency,
the syntax of `mask` shorthand should use `<coord-box>` for this two
components.

Issue: w3c#551
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant