Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert Animatable to Animation type prop definition field #531

Merged
merged 1 commit into from Mar 20, 2024

Conversation

cdoublev
Copy link
Contributor

@cdoublev cdoublev commented Sep 19, 2023

  • fixes [FXTF] Update “Animatable” lines to “Animation type” in all propdef tables #521
  • replaces all occurrences of Animatable with Animation type as a property definition field
  • replaces no with not animatable (as an Animation type value)
    • isolation edit: replaced with discrete (see following comment and 402eece)
  • replaces no with discrete
    • background-blend-mode, mix-blend-mode
    • fill-break, stroke-break
    • fill-origin, stroke-origin
    • fill-repeat, stroke-repeat
    • fill-rule
    • stroke-align
    • stroke-dash-justify
    • stroke-linecap
    • stroke-linejoin
    • stroke-miterlimit
  • replaces as repeatable list of integers with by computed value
    • stroke-dashoffset
  • replaces as repeatable list of * with as repeatable list
    • fill-image, stroke-image
    • fill-position, stroke-position
    • fill-size, stroke-size
    • stroke-dasharray
  • replaces as color with by computed value
    • fill-color, stroke-color
  • replaces as <length-percentage> with by computed value
    • stroke-width
  • replaces as number with by computed value
    • fill-opacity, stroke-opacity
  • replaces yes, if <length> with by computed value if <length>, otherwise discrete
    • stroke-dash-corner
  • replaces yes with See prose in Animation of Filters
    • backdrop-filter

@cdoublev cdoublev force-pushed the animation-type branch 2 times, most recently from 2291128 to feb29fd Compare September 19, 2023 13:28
@birtles
Copy link
Contributor

birtles commented Sep 20, 2023

Thanks for doing this. The only one I'm not sure about is isolation. Due to https://drafts.csswg.org/web-animations-1/#side-effects-section, animating to isolation: auto with a fill mode of after or both would not have the desired effect.

@w3cbot
Copy link

w3cbot commented Mar 20, 2024

svgeesus marked as non substantive for IPR from ash-nazg.

@svgeesus svgeesus merged commit 169b0e1 into w3c:main Mar 20, 2024
1 check passed
@cdoublev cdoublev deleted the animation-type branch March 20, 2024 06:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FXTF] Update “Animatable” lines to “Animation type” in all propdef tables
4 participants