Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correction: Clarify units and reference geodetic system for latitude and longitude #138

Merged
merged 2 commits into from Apr 11, 2024

Conversation

reillyeon
Copy link
Member

@reillyeon reillyeon commented Sep 12, 2023

Replace "decimal degrees" with "a real number of degrees" for greater clarity and specifically refer to the WGS84 coordinate system for latitude and longitude the way it is for altitude.

Closes #135 and #136.

CC @mgiuca and @jyasskin.


Preview | Diff

Replaces "decimal degrees" with "a real number of degrees" for greater
clarity and specifically refers to the WGS84 coordinate system for
latitude and longitude the way it is for altitude.

Fixed #135 and #136.
@jyasskin
Copy link
Member

Oh, but note that there are 2 other instances of "decimal degrees" before #135 is fixed.

@reillyeon
Copy link
Member Author

Oh, but note that there are 2 other instances of "decimal degrees" before #135 is fixed.

Done.

@marcoscaceres marcoscaceres self-requested a review April 10, 2024 02:36
Copy link
Member

@marcoscaceres marcoscaceres left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, this is a good clarification.

@marcoscaceres marcoscaceres removed the request for review from anssiko April 10, 2024 02:38
@marcoscaceres
Copy link
Member

Blocked on #148

@marcoscaceres marcoscaceres changed the title [Editorial] Clarify units and reference geodetic system for latitude and longitude Correction: Clarify units and reference geodetic system for latitude and longitude Apr 10, 2024
@marcoscaceres
Copy link
Member

@reillyeon, to automate some of this stuff, we need a convention for the commit messages. For now, slap "Correction:" on the front of the commit message.

@marcoscaceres marcoscaceres merged commit 74b1dd0 into main Apr 11, 2024
2 checks passed
@marcoscaceres marcoscaceres deleted the coordinate_system branch April 11, 2024 03:12
@marcoscaceres
Copy link
Member

Taking so I can work on #148

github-actions bot added a commit that referenced this pull request Apr 11, 2024
…and longitude (#138)

SHA: 74b1dd0
Reason: push, by marcoscaceres

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

What does "decimal degrees" mean?
3 participants