Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

input type=submit and reset need further updates #471

Closed
scottaohara opened this issue Apr 12, 2023 · 0 comments · Fixed by #472
Closed

input type=submit and reset need further updates #471

scottaohara opened this issue Apr 12, 2023 · 0 comments · Fixed by #472

Comments

@scottaohara
Copy link
Member

in resolving #357 the missing step about using the label element was added, but this was not reflected in later text that refers to step 1 or 2, ignoring the fact there are now 3 steps. In reviewing this further, i determined this could be clarified further - which is explained in the PR to resolve this issue.

scottaohara added a commit that referenced this issue Apr 12, 2023
closes #471

in resolving #357, I failed to update the text that says "if steps 1 to 2..." - as the inclusion of label added a 3rd step.
Looking at this further though, it seemed this could be clarified a bit more as the previous steps made it seem like if `value=""` was used, that the localized text strings of submit or reset should be used.  but that's not how this shakes out in reality, where if a value attribute is used, even if it's value is the empty string, it will become the control's accessible name.  

so the revised text is an attempt to make that clear, and purposefully removes saying to use the localized text string of submit or reset, since those can vary per browser.  Rather, I refer to these now as HTML does by saying the "implementation defined string".

The title attribute step was update to reference the fact that someone _could_ do <input type=submit value>` which would mean the button had no accName, so if that's the case, then `title` should be used.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant