Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update UIA mappings for control type: text #531

Open
scottaohara opened this issue Feb 6, 2024 · 3 comments
Open

Update UIA mappings for control type: text #531

scottaohara opened this issue Feb 6, 2024 · 3 comments

Comments

@scottaohara
Copy link
Member

per the rational behind #524, the current UIA mappings for other HTML elements legend, abbr, ruby, figcaption are incorrect as these do not always represent text leaf nodes, and rather can quite often contain structured content.

Need to make a PR for these changes.

@benbeaudry will there also need to be changes in chromium? Or is this actually fine in reality and just wrong in the spec? If the former, can you please handle making the issue to fix and follow suit with the change for the label element?

@benbeaudry
Copy link

ruby is the only one already exposed as Group in Chromium. I'll file the bugs for the other mappings and fix it over there.

aarongable pushed a commit to chromium/chromium that referenced this issue Feb 7, 2024
Text elements in UIA should be leaf nodes. <abbr> can contain a
subtree of text nodes. We are updating the html-aam spec and Chromium
to fix this mistake: w3c/html-aam#531.

Fixed: 324114899
Change-Id: If99192ca4ead55e9d1a1c4d9e50188fb0cd1b77f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5274040
Commit-Queue: Benjamin Beaudry <benjamin.beaudry@microsoft.com>
Reviewed-by: Kurt Catti-Schmidt <kschmi@microsoft.com>
Cr-Commit-Position: refs/heads/main@{#1257467}
aarongable pushed a commit to chromium/chromium that referenced this issue Feb 7, 2024
Text elements in UIA should be leaf nodes. <figcaption> can contain a
subtree of text nodes. We are updating the html-aam spec and Chromium
to fix this mistake: w3c/html-aam#531.

Fixed: 324112188
Change-Id: I069f4f152fd82e6c7cb9aa9942516047c6b6d57c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5274133
Reviewed-by: Kurt Catti-Schmidt <kschmi@microsoft.com>
Commit-Queue: Benjamin Beaudry <benjamin.beaudry@microsoft.com>
Cr-Commit-Position: refs/heads/main@{#1257472}
aarongable pushed a commit to chromium/chromium that referenced this issue Feb 7, 2024
Text elements in UIA should be leaf nodes. <legend> can contain a
subtree of text nodes. We are updating the html-aam spec and Chromium
to fix this mistake: w3c/html-aam#531.

Fixed: 324112189
Change-Id: I1a3b3e7cc7c251bc5653fe35871d8e64a6e0a6a7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5275269
Reviewed-by: Kurt Catti-Schmidt <kschmi@microsoft.com>
Auto-Submit: Benjamin Beaudry <benjamin.beaudry@microsoft.com>
Commit-Queue: Benjamin Beaudry <benjamin.beaudry@microsoft.com>
Cr-Commit-Position: refs/heads/main@{#1257475}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants