Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addition: Revise address element to map to role=group #420

Merged
merged 6 commits into from
Jul 19, 2022

Conversation

scottaohara
Copy link
Member

@scottaohara scottaohara commented Jul 2, 2022

Per discussion of <address> in #373, WG had no objections to mapping the element to the group role.


Preview | Diff

Per discussion `<address>` in #373, WG had no objections to mapping the element to the `group` role.
@scottaohara
Copy link
Member Author

scottaohara commented Jul 8, 2022

chromium & gecko bugs / implementation requests filed

created a test case for comparative purposes:
https://codepen.io/scottohara/pen/RwMayEz

@scottaohara scottaohara changed the title Revise address element to map to role=group Addition: Revise address element to map to role=group Jul 8, 2022
@scottaohara
Copy link
Member Author

with 3 approvals and bugs filed, I'm merging this PR.

@scottaohara scottaohara merged commit 4310e8d into gh-pages Jul 19, 2022
@scottaohara scottaohara deleted the address-group-role branch July 19, 2022 13:56
aarongable pushed a commit to chromium/chromium that referenced this pull request Aug 12, 2022
See HTML-AAM changes: w3c/html-aam#420
Summary of changes:
- IA2 role changed from IA2_ROLE_SECTION to ROLE_SYSTEM_GROUPING
- ATK role changed from "section" to "panel"
- AXAPI added AXSubrole: AXApplicationGroup

Fixed: 1342807
Change-Id: Idccc5324ad582b809e020676f5057c803fd4962c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3821228
Commit-Queue: Valerie Young <spectranaut@igalia.com>
Reviewed-by: Aaron Leventhal <aleventhal@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1034533}
mjfroman pushed a commit to mjfroman/moz-libwebrtc-third-party that referenced this pull request Oct 14, 2022
See HTML-AAM changes: w3c/html-aam#420
Summary of changes:
- IA2 role changed from IA2_ROLE_SECTION to ROLE_SYSTEM_GROUPING
- ATK role changed from "section" to "panel"
- AXAPI added AXSubrole: AXApplicationGroup

Fixed: 1342807
Change-Id: Idccc5324ad582b809e020676f5057c803fd4962c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3821228
Commit-Queue: Valerie Young <spectranaut@igalia.com>
Reviewed-by: Aaron Leventhal <aleventhal@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1034533}
NOKEYCHECK=True
GitOrigin-RevId: 7394789e8990f3ccaa9558386214737dc4f03b26
@scottaohara
Copy link
Member Author

note: confirmed that public version of Chrome and Firefox now expose address with role=group

scottaohara added a commit to w3c/html-aria that referenced this pull request Nov 3, 2022
per the changes to HTML AAM - w3c/html-aam#420
closes #426

Firefox and Chromium browsers have been confirmed to expose address with a group role.  Webkit does not appear to have made this change yet, but someone using macOS with VoiceOver would be none the wiser, since it'll still communicate `<address aria-label=foo>` as a 'group' even though it has not been officially mapped as such.

This is marked as an editorial update as the implicit mapping column is a reflection of reality, and the implicit roles are not defined by this specification.
pkra pushed a commit to w3c/aria that referenced this pull request May 20, 2024
per the changes to HTML AAM - w3c/html-aam#420
closes #426

Firefox and Chromium browsers have been confirmed to expose address with a group role.  Webkit does not appear to have made this change yet, but someone using macOS with VoiceOver would be none the wiser, since it'll still communicate `<address aria-label=foo>` as a 'group' even though it has not been officially mapped as such.

This is marked as an editorial update as the implicit mapping column is a reflection of reality, and the implicit roles are not defined by this specification.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants