-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Correction: add missing label elm to 'button' naming steps #423
Conversation
adds label element to `button`, `input type=button|submit|reset|image`. This is a long overdue update and there could be more clarity here. However, getting this perfect has long stood in the way of getting this done, and I would rather get this gap resolved to match reality, and then better describe this in a follow revision to these naming steps.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I feel like this HTML-AAM specific algorithm may start to get to complicated unless it's explicit where each of these steps fits into the main AccName algorithm. For example:
- Step 1 (aria-label, etc here) is redundant with AccName...
- Steps 2 and 3 (label el, value attr) fits into the "host language label mechanism" portion of AccName
- Steps 4 and 5 (title and placeholder attrs) fit into the host language tooltip mechanism portion of AccName.
- then the final step would be the element-specific fallback label
@cookiecrook yes, and this is where some of the cleanup i'm trying to do in another future PR would come into play. But there are some elements that don't fit neatly with the way that accName is setup. E.g., there are some elements where name from content (accName F) takes precedent over the |
Okay then. I approve this diff as-is. Thanks for the follow-up. |
adds label element to
button
,input type=button|submit|reset|image
.This is a long overdue update and there could be more clarity here. However, getting this perfect has long stood in the way of getting this done, and I would rather get this gap resolved to match reality, and then better describe this in a follow revision to these naming steps.
Closes #357 - companion PR to #402
Preview | Diff