Computed role re-add #519
Merged
Computed role re-add #519
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
closes #511 Incorporates a version of the `computedrole` content from core aam, and re-adds all the instances of computed roles which were accidentally dropped when changing the spec from one giant table with details/summary plugin to individual tables.
|
@spectranaut @jnurthen i'm not sure what happened that this apparently didn't get triaged / reviewers assigned. but i would appreciate someone doing a quick check to make sure i've re-added all the information that we lost when the spec was converted to be table-only. |
spectranaut
approved these changes
Feb 2, 2024
jnurthen
approved these changes
Feb 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #511
Incorporates a version of the
computedrolecontent from core aam, and re-adds all the instances of computed roles which were accidentally dropped when changing the spec from one giant table with details/summary plugin to individual tables.Preview | Diff