Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

separator role on button #488

Closed
stevefaulkner opened this issue Aug 30, 2023 · 3 comments · Fixed by #489
Closed

separator role on button #488

stevefaulkner opened this issue Aug 30, 2023 · 3 comments · Fixed by #489

Comments

@stevefaulkner
Copy link
Collaborator

Gerard Cohen asked me why role=separator is not allowed on a button element. From reading the definition in the aria spec, i don't see a reason not to allow.

you wizened souls may think otherwise?
@scottaohara
Copy link
Member

naw, that seems quite reasonable esp. since it can represent an interactive control that a button could reasonably serve as a base for.

scottaohara added a commit that referenced this issue Aug 30, 2023
@scottaohara
Addition: allow role=separator on button elements
59a60e5 
closes #488 

allows role=separator on elements exposed as a button.  

any other author requirements for appropriately setting that up / ensuring the correct information is communicated would still need to be evaluated, but separate from whether the role is allowed or not.
@scottaohara scottaohara mentioned this issue Aug 30, 2023
Merged
4 tasks
@scottaohara
Copy link
Member

and boosh. easy PRs are easy. gotta inform the checkers now / get some implementation commitments to acknowledge this change, and then it can be merged if good to go

@gerardkcohen gerardkcohen mentioned this issue Aug 31, 2023
Open
1 task
@gerardkcohen
Copy link

Thanks @stevefaulkner and @scottaohara

scottaohara added a commit that referenced this issue Oct 4, 2023
@scottaohara
Addition: allow role=separator on button elements (#489)
9e49525 
closes #488 

allows role=separator on elements exposed as a button.  

any other author requirements for appropriately setting that up / ensuring the correct information is communicated would still need to be evaluated, but separate from whether the role is allowed or not.

* Addition: allow role=separator on button elements
* update changelog
@thebjorn thebjorn mentioned this issue May 4, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Addition: allow role=separator on button elements w3c/html-aria
3 participants
@gerardkcohen @stevefaulkner @scottaohara