Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correction: revise wbr and br element allowances #353

Merged
merged 10 commits into from
Dec 8, 2021

Conversation

scottaohara
Copy link
Member

@scottaohara scottaohara commented Sep 23, 2021

closes #332

Revise the allowances for the br element - only allow aria-hidden attribute, rather than all global attributes.

Revise allowances for wbr to match br. Neither of these elements allow for styling from authors, nor do they allow for child content (or content from CSS - again no styling). So allowing for any roles/attributes beyond presentation or for hiding would not be a wise idea.

Need at least two checkers to accept this change before we can merge.

html validator

  • role update
  • allowed attributes update

ibm equal access accessibility checker

  • role update
  • allowed attributes update

axe-core

  • role update
  • allowed attributes update

arc toolkit

  • role update
  • allowed attributes update

html validator and axe issues are still open in regards to limiting allowed aria-* attributes on these elements to aria-hidden alone.


Preview | Diff

@scottaohara scottaohara added the needs implementation commitment Cannot merge into spec until implementations in conformance checkers has been confirmed. label Sep 23, 2021
@scottaohara scottaohara added the Meets 2 implementations req Indicates that a spec change has met the necessary 2 implementations needed to merge. label Oct 8, 2021
@scottaohara
Copy link
Member Author

This can now be merged after the 1.0 spec officially meets Rec status.

index.html Outdated Show resolved Hide resolved
index.html Outdated Show resolved Hide resolved
@scottaohara scottaohara removed the Meets 2 implementations req Indicates that a spec change has met the necessary 2 implementations needed to merge. label Oct 26, 2021
@scottaohara scottaohara changed the title revise wbr and br element allowances Correction: revise wbr and br element allowances Nov 8, 2021
@scottaohara scottaohara removed the needs implementation commitment Cannot merge into spec until implementations in conformance checkers has been confirmed. label Dec 8, 2021
@scottaohara
Copy link
Member Author

As 3 of the 4 checkers have already updated the role allowances for wbr, and intent to implement the additional aria-* allowances for br and wbr has met no opposition, I'm going to merge this into the spec.

@scottaohara scottaohara merged commit cfab4e1 into gh-pages Dec 8, 2021
@scottaohara scottaohara deleted the 332-wbr-and-br-element branch December 8, 2021 01:06
scottaohara added a commit that referenced this pull request May 19, 2022
directly reference the following PRs in the changelog, and prepend each entry with the appropriate 'label'

related to #419

- #352
- #367 (and follow on [commit](887c772))
- #360
- #353
- #372
- #402
- #404
- #403
- #396
- #391
- #369
- #381
pkra pushed a commit to w3c/aria that referenced this pull request May 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

wbr element
3 participants