Editorial: clarify summary element role mapping #434
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes #355 Since the original issue was filed, and I have spent more time researching details/summary and trying to get consensus on what to do with the summary element in particular, I think it does make sense to adjust this per JAWS-test's issue. The role is now stated as "no corresponding role" since there is no direct ARIA mapping in HTML AAM, but the note was added to indicate the reality of how the role is actually mapped.
scottaohara
commented
Nov 2, 2022
patrickhlauke
approved these changes
Nov 2, 2022
stevefaulkner
approved these changes
Nov 2, 2022
|
However, the permitted attributes still state:
I suggest removing that as well, since the attributes are not meaningful (e.g. aria-haspopup) or contradict implicit attributes of the HTML element (aria-expanded) |
|
you're right @JAWS-test. but that will need to be considered a normative change. so we need to do that separate. |
scottaohara
added a commit
that referenced
this pull request
Nov 2, 2022
Normative follow-on from #434 The spec was updated to note that the summary element doesnt' always map to the button element. The allowed attributes indicated that all attributes that were applicable to the button role were allowed. However, in practice this doesn't make sense and could break or be in contradiction to the implicit semantics. The allowed aria-* attributes for the button role include * aria-disabled * aria-haspopup * aria-expanded * aria-pressed Of those four, aria-expanded and pressed are the ones that would pose problems by conflicting or not making any sense with the implicit expanded/collapsed states provided by the element (who gets the state per the parent details having an open attribute or not).
4 tasks
scottaohara
added a commit
that referenced
this pull request
May 31, 2023
…ary element (#435) * revise allowed attributes on summary element Normative follow-on from #434 The spec was updated to note that the summary element doesnt' always map to the button element. The allowed attributes indicated that all attributes that were applicable to the button role were allowed. However, in practice this doesn't make sense and could break or be in contradiction to the implicit semantics. The allowed aria-* attributes for the button role include * aria-disabled * aria-haspopup * aria-expanded * aria-pressed Of those four, aria-expanded and pressed are the ones that would pose problems by conflicting or not making any sense with the implicit expanded/collapsed states provided by the element (who gets the state per the parent details having an open attribute or not). * further clarifications for summary element allowances this addition to the PR takes into account that only a summary element that serves as the 'summary for its parent details' needs to adhere to these rules. otherwise, a summary element that doesn't meet the criteria of the HTML spec is essentially just a generic element, so any roles/attributes can be used on that. * updated changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #355
Since the original issue was filed, and I have spent more time researching details/summary and trying to get consensus on what to do with the summary element in particular, I think it does make sense to adjust this per JAWS-test's issue. The role is now stated as "no corresponding role" since there is no direct ARIA mapping in HTML AAM, but the note was added to indicate the reality of how the role is actually mapped.
This PR contains no normative changes, as element roles are not defined by this specification.
Preview | Diff