Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update test suite #7

Closed
anssiko opened this issue Feb 23, 2017 · 21 comments

Comments

Projects
None yet
4 participants
@anssiko
Copy link
Member

commented Feb 23, 2017

@Honry (or @zqzhang, test suite owner) Could you help update the test suite to match the recent changes that addressed issue #4.

See the HTML diff comparing the spec just before and after the following changes:
0a3564e
ccd71a1
991921e

Latest Editor's Draft:
https://w3c.github.io/html-media-capture/

Test suite (matches CR currently):
http://w3c-test.org/html-media-capture/
https://github.com/w3c/web-platform-tests/tree/master/html-media-capture

I think we need at least the following tests updated/added:

  • update IDL harness tests
  • user
  • environment
  • invalid value default
  • missing value default

@riju is working to update the Chromium implementation to match.

@Honry

This comment has been minimized.

Copy link

commented Feb 23, 2017

Yes, I can help update the test suite.

@Honry

This comment has been minimized.

Copy link

commented Feb 23, 2017

@anssiko or @riju, could you please inform me once the update in Chromium implementation is done? Thus I can verify the tests.

@riju

This comment has been minimized.

Copy link

commented Feb 23, 2017

@Honry : sure, will update soon.

@anssiko

This comment has been minimized.

Copy link
Member Author

commented Mar 7, 2017

WIP Chromium implementation: https://crbug.com/698853

@anssiko

This comment has been minimized.

Copy link
Member Author

commented Mar 28, 2017

@Honry, HTML Media Capture implementation (based on the latest Editor's Draft) now ships in Safari 10.1 / iOS 10.3. Could you update the test suite and create a test report (example) for it with iOS Safari results?

@riju, could you update the Chromium implementation so that the updated IDL tests will pass on Chromium? Even with the known Android API limitation, such an implementation would be spec conformant given the preferred facing mode is a hint and the spec gives leeway for implementations to fall back to the implementation-specific default facing mode, if the user agent is unable to support the preferred facing mode.

@Honry

This comment has been minimized.

Copy link

commented Mar 28, 2017

@anssiko, sure. I will update soon.

@riju

This comment has been minimized.

Copy link

commented Mar 28, 2017

@anssiko, yes will update my CL soon.

@anssiko

This comment has been minimized.

Copy link
Member Author

commented Mar 28, 2017

@Honry @riju, thanks!

@dontcallmedom, given good progress on the implementation front, I think we should try to publish a revised Candidate Recommendation soon. Could you help obtain the required Director's approval to publish a CR revision?

@dontcallmedom

This comment has been minimized.

Copy link
Member

commented Mar 28, 2017

@anssiko before doing the transition request, we need to confirm there is WG consensus for the updated CR, and check whether we need reviews from specific groups on the said change. Maybe start a thread on the mailing list?

@anssiko

This comment has been minimized.

Copy link
Member Author

commented Mar 28, 2017

Honry added a commit to Honry/web-platform-tests that referenced this issue Apr 1, 2017

Honry added a commit to Honry/web-platform-tests that referenced this issue Apr 1, 2017

Honry added a commit to Honry/web-platform-tests that referenced this issue Apr 1, 2017

Honry added a commit to Honry/web-platform-tests that referenced this issue Apr 1, 2017

Honry added a commit to Honry/web-platform-tests that referenced this issue Apr 1, 2017

@Honry

This comment has been minimized.

Copy link

commented Apr 1, 2017

@anssiko, I just updated the tests, could you help review it? I will create a test report with iOS Safari once the tests are merged.

@anssiko

This comment has been minimized.

Copy link
Member Author

commented Apr 3, 2017

@Honry the updated tests look good to me, thanks!

@Honry

This comment has been minimized.

Copy link

commented Apr 5, 2017

@anssiko, the test report for Safari 10.1 is ready at w3c/test-results#89.
I capture one bug that the browser always launch camera when the capture attribute is set and the accept attribute is set to 'audio/*' or 'text/plain' (Note: bug has been reported to Apple but without open link as it is close source).
Please help review it. :)

@anssiko

This comment has been minimized.

Copy link
Member Author

commented Apr 6, 2017

The CfC to publish a revised CR passed with no concerns so I expect us to be able to publish an updated CR shortly.

@Honry, do you think you could land w3c/test-results#89 soon so we could link to it in from the revised CR specification?

@Honry

This comment has been minimized.

Copy link

commented Apr 7, 2017

@anssiko, shall we wait for the test result with Chromium?

@anssiko

This comment has been minimized.

Copy link
Member Author

commented Apr 7, 2017

We can add Chromium in a subsequent update. Please replace the duplicate column in the report with a placeholder for Chromium and merge the report.

@Honry

This comment has been minimized.

Copy link

commented Apr 7, 2017

Done, please check. :)

Honry added a commit to web-platform-tests/wpt that referenced this issue Apr 7, 2017

@anssiko

This comment has been minimized.

Copy link
Member Author

commented Apr 24, 2017

@riju, could you give us an update on the Chromium implementation status?

The spec will transition to Candidate Recommendation on 04 May 2017 and it would be great to have the implementation ready by that date.

@riju

This comment has been minimized.

Copy link

commented Apr 25, 2017

@anssiko : I have the chromium CL almost ready for review. Need to test a bit more. Will update this thread, when it goes in.

@anssiko

This comment has been minimized.

Copy link
Member Author

commented Apr 28, 2017

The Chrome for Android data has been added to the test results:

http://w3c.github.io/test-results/html-media-capture/20170428.html

The implementation status wiki has been updated accordingly:

https://www.w3.org/2009/dap/wiki/ImplementationStatus

Thanks @Honry!

@anssiko

This comment has been minimized.

Copy link
Member Author

commented May 10, 2017

The test suite has been updated, and we have test results.

Closing this issue. For the latest results please refer to the implementation report linked from the spec header too.

@anssiko anssiko closed this May 10, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.