Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase contrast #300

Open
wants to merge 1 commit into
base: gh-pages
Choose a base branch
from
Open

Increase contrast #300

wants to merge 1 commit into from

Conversation

xfq
Copy link
Member

@xfq xfq commented Jun 4, 2021

Make the links in the sidebar clearer.

Make the links in the sidebar clearer.
@r12a
Copy link
Contributor

r12a commented Jun 9, 2021

@xfq it's not clear to me which links you have a problem with in the sidebar. Sidebar links on a beige background should be a slate grey colour. Do you mean links in side notes? Changing that line in the CSS doesn't seem to produce a difference for me. Perhaps you could post here a picture of what you're wanting to change.

@xfq
Copy link
Member Author

xfq commented Jun 9, 2021

I'm talking about the breadcrumb navigation:

links

It may be because of the color difference. I can see them clearly on one monitor, but they are not so clear on another monitor.

@r12a
Copy link
Contributor

r12a commented Jun 9, 2021

Thanks, i now understand which links you are concerned about.

However, the teal and #007575 colours seem the same to me. Could you check that?

@xfq
Copy link
Member Author

xfq commented Jun 10, 2021

The two colours are similar, but not exactly the same (#008080 and #007575). I tried not to change the original colour scheme as much as possible, so I didn't make major adjustments.

@r12a
Copy link
Contributor

r12a commented Jun 10, 2021

Understood. It's just that, when flipping between the 2 colours using the inspector, i see no difference at all to the contrast of the text. I suppose that's a good thing, since it means there's no harm done, but if there's a difference on one of your systems i wonder what the differences are for others we haven't seen. Anyway, i suppose we can go ahead.

(One reason for me to hesitate is that it's much easier to remember and type 'teal' than #007575, but such is life. I'd be curious to see the same image you added above with the alternate colour, and to know whether you and i see the 2 images differently. If you have a spare moment?)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants