Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

translate definitions-time into zh-hans #372

Merged
merged 3 commits into from
Jun 6, 2022
Merged

translate definitions-time into zh-hans #372

merged 3 commits into from
Jun 6, 2022

Conversation

cuihuan
Copy link
Contributor

@cuihuan cuihuan commented May 26, 2022

@r12a r12a mentioned this pull request May 26, 2022
Open
@r12a
Copy link
Contributor

r12a commented May 26, 2022

Is this still WIP ?

@cuihuan
Copy link
Contributor Author

cuihuan commented May 26, 2022

Is this still WIP ?

Yes, I'll correct the details later.

@cuihuan cuihuan changed the title [WIP] translate definitions-time into zh-hans translate definitions-time into zh-hans May 26, 2022
@cuihuan
Copy link
Contributor Author

cuihuan commented May 26, 2022

@xfq Translation completed, thank you for CR
In addition, do we have a i18n or time vocabulary?

@r12a r12a requested a review from xfq May 26, 2022 07:35
@r12a
Copy link
Contributor

r12a commented May 26, 2022

@xfq could you review this translation? Once it passes, i'll update the tracker and announce the 2 zh-hans translations we have pending.

@xfq
Copy link
Member

xfq commented May 31, 2022

do we have a i18n or time vocabulary?

We have https://www.w3.org/TR/i18n-glossary/ , and if you think there are terms that need to be added, feel free to file issues in https://github.com/w3c/i18n-glossary/issues/ . We also welcome translations of the document.

@cuihuan cuihuan requested a review from xfq May 31, 2022 07:38
@cuihuan
Copy link
Contributor Author

cuihuan commented May 31, 2022

do we have a i18n or time vocabulary?

We have https://www.w3.org/TR/i18n-glossary/ , and if you think there are terms that need to be added, feel free to file issues in https://github.com/w3c/i18n-glossary/issues/ . We also welcome translations of the document.

thanks , i will try to translate this document.

@r12a r12a merged commit dd49525 into w3c:gh-pages Jun 6, 2022
@r12a
Copy link
Contributor

r12a commented Jun 6, 2022

Merged. Thank you. (Note: there is at least one small divergeance from the new template format, so i will update the translation to fix that this morning.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xfq xfq xfq approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@cuihuan @r12a @xfq