Translate qa-when-lang-neg into Chinese #374
Conversation
| @@ -227,7 +227,11 @@ var modCredit = '' | |||
| if (f.modifiers && f.modifiers != '') modCredit = s.modifiedBy+' '+f.modifiers+s.sentenceDelimiter | |||
|
|
|||
| var translatorCredit = '' | |||
| if (g.isTranslation) translatorCredit = s.translatedBy+' '+f.translators+s.sentenceDelimiter | |||
| if (g.isTranslation) { | |||
| // Remove the space in Chinese | |||
There was a problem hiding this comment.
An alternative approach would be to include the space in s.translatedBy. It wouldn't take a lot of work to change the code, but it would avoid the need to extend the list of exceptions for other languages, give more flexibility, and reduce the code complexity.
There was a problem hiding this comment.
It would also solve the problem for all these other cases:
s.author = "By:" // followed by name of author(s)
s.previousAuthors = "Previously by:" // followed by name of previous author(s), before substantive changes were made by the current author
s.modifiedBy = "Changed by:" // person's name appears after colon
(there may be some more)
I'd suggest changing the boilerplate text files to say
s.translatedBy = "Translator:"+" "
For Chinese that would be +"".
I can make this change, if you like. You'd need to remove the changes from this PR.
|
I think we need to split this PR. Since you're making changes to the javascript structure and boilerplate files, we need to alter the boilerplate text for all languages before merging – otherwise we'll break all the other translations. I suggest that you remove those changes from this PR, and i'll change the boilerplate files and make those changes (i'll do it now). That's also cleaner, since it will produce different commits for alterations to the template and for the translation. |
|
I implemented the fixes to all the boilerplate-xx.js files and to the xxx-2022.js files, so you can remove those from the pull request now. Then we might be ready to merge, but i'll double-check after you make the alterations. |
Removed. Please check. |
This PR: