align datetime value to contents in time #411
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for i18n-drafts ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
|
@himorin many thanks for spotting this. Actually, when i looked at that article i noticed that many of the items listing browser support were out of date. I have therefore begun applying the latest template to the article (which shows live results in the article itself) and updating the test results. I'll try to integrate these changes you suggest at the same time. I'll let you know when i get further with the conversion. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Text within time element says
2015年5月22日, but datetime attribute has2016-05-22. This PR fixes these difference.These are just test cases or pure example for tate-chu-yoko, so there seems no intention to change between attribute and text.