Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translate qa-text-processing-vs-metadata into zh-hans #433

Merged
merged 4 commits into from
Feb 13, 2023

Conversation

xfq
Copy link
Member

@xfq xfq commented Dec 5, 2022

No description provided.

@xfq xfq requested a review from r12a December 5, 2022 07:41
@r12a
Copy link
Contributor

r12a commented Dec 14, 2022

  1. the contrastive highlighting of " what specific language it is dealing with for a specific range of text." and "about the document/resource as a whole." appears to be lost in the chinese version. Is there something we can do to show that emphasis? (emphasis dots? bracketing? colour change? font change? etc)
  2. we changed the 'follow us' links to include Mastodon, so you'll need to adapt that in the translation.

Otherwise, LGTM, thanks.

@r12a
Copy link
Contributor

r12a commented Dec 14, 2022

we changed the 'follow us' links to include Mastodon, so you'll need to adapt that in the translation

To be more clear, the boilerplate should handle the new structure, and the visible text, but if the title attribute text needs to be adapted for chinese that will need attention. (Maybe not.)

@xfq
Copy link
Member Author

xfq commented Dec 15, 2022

Thanks for your review!

  1. the contrastive highlighting of " what specific language it is dealing with for a specific range of text." and "about the document/resource as a whole." appears to be lost in the chinese version. Is there something we can do to show that emphasis? (emphasis dots? bracketing? colour change? font change? etc)

I've tweaked the colour and font weight to make it clearer.

  1. we changed the 'follow us' links to include Mastodon, so you'll need to adapt that in the translation.

This is generated by the boilerplate and has nothing to do with the Chinese translation of this article. I'll check the text of the boilerplate (separately).

@netlify
Copy link

netlify bot commented Feb 13, 2023

Deploy Preview for i18n-drafts ready!

Name Link
🔨 Latest commit a49f643
🔍 Latest deploy log https://app.netlify.com/sites/i18n-drafts/deploys/63e9af52808d080008337950
😎 Deploy Preview https://deploy-preview-433--i18n-drafts.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@w3c w3c deleted a comment from netlify bot Feb 13, 2023
@xfq xfq merged commit d8f88d1 into gh-pages Feb 13, 2023
@xfq xfq deleted the xfq/qa-text-processing-vs-metadata.zh-hans branch February 13, 2023 03:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants