-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update the name of the typography index #445
Conversation
✅ Deploy Preview for i18n-drafts ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor nit.
@@ -153,7 +153,7 @@ <h2>Text layout index</h2> | |||
|
|||
<figure id="fig_layout_index"> | |||
<img src="language_framework_overview-data/layout_index.png" alt=""> | |||
<figcaption>A small section in the International text layout and typography index.</figcaption> | |||
<figcaption>A small section in the Language enablement index.</figcaption> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Either title case it (Language Enablement
) or lower case it (language enablement
). The other occurrences are sentence start, hence the initial cap.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you look at the document title https://www.w3.org/TR/typography/ it is downstyled: ie. Language enablement index. I don't have very strong views on whether or not to retain the downstyling, although if it is link text or highlighted or marked by punctuation in some other way it may be better to keep it.
Note however that if capitalisation is applied, it needs to be applied to all 3 words in the title, not just "Language Enablement" if the title is being quoted (which probably is the case at least most of the time).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It might be downstyled in the document itself, but it should be treated as a title elsewhere. Otherwise it is super confusing (c.f. this pull request!... ooh, I used a Latin abbreviation... yikes!!) Or we should mark "Language enablement index" with <cite>
.
In any case, in English the normal behavior for titlecase is to capitalize the first word and all nouns, pronouns, adjectives, verbs and adverbs, but not articles, conjunctions or prepositions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have added a link, so I think it's less ambiguous now. Are you OK with it, @aphillips?
See the figure caption in https://deploy-preview-445--i18n-drafts.netlify.app/pages/language_framework_overview.html#fig_layout_index for the preview.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See discussion of titlecasing. Also, check the link.
@@ -153,7 +153,7 @@ <h2>Text layout index</h2> | |||
|
|||
<figure id="fig_layout_index"> | |||
<img src="language_framework_overview-data/layout_index.png" alt=""> | |||
<figcaption>A small section in the International text layout and typography index.</figcaption> | |||
<figcaption>A small section in the Language enablement index.</figcaption> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It might be downstyled in the document itself, but it should be treated as a title elsewhere. Otherwise it is super confusing (c.f. this pull request!... ooh, I used a Latin abbreviation... yikes!!) Or we should mark "Language enablement index" with <cite>
.
In any case, in English the normal behavior for titlecase is to capitalize the first word and all nouns, pronouns, adjectives, verbs and adverbs, but not articles, conjunctions or prepositions.
Merging per yesterday's i18n WG Teleconference. |
No description provided.