Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QA escapes: FR translation + minor changes to EN #446

Merged
merged 2 commits into from Feb 27, 2023

Conversation

clavoline
Copy link
Contributor

Submitting a French translation of "questions/qa-escapes" and a few changes to the English version.

  1. For consistency purposes:
  • Replaced <span class="leading"> and </span> with <strong class="leading"> and </strong> in two instances
  • Added <code> and </code> around character references in four instances
  1. Added a link to a section on the same page

  2. Replaced three obsolete links

  3. Modified two links that pointed to different pages but had the same anchor text

@netlify
Copy link

netlify bot commented Feb 12, 2023

Deploy Preview for i18n-drafts ready!

Name Link
🔨 Latest commit 3e706ca
🔍 Latest deploy log https://app.netlify.com/sites/i18n-drafts/deploys/63ef7f002c69310008eeb503
😎 Deploy Preview https://deploy-preview-446--i18n-drafts.netlify.app/questions/qa-escapes.fr
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@r12a
Copy link
Contributor

r12a commented Feb 14, 2023

@clavoline thank you very much for useful edits to the english !

I haven't looked at the French yet because the netlify link didn't work. @xfq is it possible to fix that? (If not, i'll install the text in a local file to check it.)

@r12a
Copy link
Contributor

r12a commented Feb 15, 2023

@r12a
Copy link
Contributor

r12a commented Feb 15, 2023

@clavoline i have now looked at the French translation and it looks good, with one caveat: near the beginning you translated the Unicode name for a character, U+00A0 ESPACE INSÉCABLE. It's normal to leave the uppercase name exactly as it appears in the standard, however, i know that there is a French version of the Unicode Standard which does have translated character names (and by memory i think you have the right name). Therefore this may not be a problem. I just wanted to check with you that you were aware. Just let me know, and if you want to keep it as is then i'll merge and announce the translation.

@clavoline
Copy link
Contributor Author

clavoline commented Feb 15, 2023 via email

@r12a
Copy link
Contributor

r12a commented Feb 16, 2023

In this article, the names have been translated as "U+00E1 Lettre minuscule latine A accent aigu", "U+0061 Lettre minuscule latine A" and "U+0301 Diacritique accent aigu". These names match the recommendations from the Hapax website.

Thanks for pointing that out. I'll change that page.

I was indeed referring to the Hapax page, which is the work of Patrick Andries. Patrick only uses lowercase on that page for notes: the actual character names are all in majuscule. So if that's where you got your translations from then i think we're already good to go, and i should just merge this. I'll wait for your reaction before doing so.

@clavoline
Copy link
Contributor Author

clavoline commented Feb 16, 2023 via email

@r12a

This comment was marked as outdated.

@r12a

This comment was marked as outdated.

@r12a
Copy link
Contributor

r12a commented Feb 16, 2023

I just checked Patrick's book on Unicode and he does refer to 'plans complémentaires'. So i stand corrected. :-)

@clavoline
Copy link
Contributor Author

clavoline commented Feb 16, 2023 via email

@r12a
Copy link
Contributor

r12a commented Feb 17, 2023

Do you want me to make the changes?

You're the translator; i rely on your judgement. ;-)

@clavoline
Copy link
Contributor Author

@r12a Hi, I made the changes we discussed, but since I'm new to Git, I might have skipped a step. Is there anything else I need to do?

@r12a
Copy link
Contributor

r12a commented Feb 27, 2023

@clavoline thanks for the prompt. Looks good to me. I think we're ready to publish. I'll take it from here, thanks.

@r12a r12a merged commit 3f0436a into w3c:gh-pages Feb 27, 2023
@clavoline clavoline deleted the french-qa-escapes branch February 27, 2023 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants