Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

French translation of QA Byte Order Mark #477

Merged
merged 5 commits into from
Jul 28, 2023
Merged

Conversation

clavoline
Copy link
Contributor

@clavoline clavoline commented May 30, 2023

@r12a The following sequence of characters appears twice in the document: 
It represents the BOM signature in the Latin 1 encoding.
Should we wrap it in a tag?

Rendered: https://deploy-preview-477--i18n-drafts.netlify.app/questions/qa-byte-order-mark.fr.html

@netlify
Copy link

netlify bot commented May 30, 2023

Deploy Preview for i18n-drafts ready!

Name Link
🔨 Latest commit be788ad
🔍 Latest deploy log https://app.netlify.com/sites/i18n-drafts/deploys/64baebcb69b05b0008e453da
😎 Deploy Preview https://deploy-preview-477--i18n-drafts.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@clavoline
Copy link
Contributor Author

Sorry, I forgot to create a new branch to submit another translation ("Languages using right-to-left scripts").

@r12a
Copy link
Contributor

r12a commented Jul 18, 2023

@clavoline Sorry, the post on 30 May seems to have passed by me unactioned. I'll take a look now.

@r12a
Copy link
Contributor

r12a commented Jul 18, 2023

The following sequence of characters appears twice in the document:  It represents the BOM signature in the Latin 1 encoding. Should we wrap it in a tag?

Actually, i think that's a good idea. Perhaps wrap it in <code> tags.

questions/qa-scripts.en.html Outdated Show resolved Hide resolved
questions/qa-scripts.en.html Outdated Show resolved Hide resolved
questions/qa-byte-order-mark.en.html Outdated Show resolved Hide resolved
@r12a
Copy link
Contributor

r12a commented Jul 18, 2023

@clavoline Thanks, as always, for your excellent suggestions wrt the source text. Just a few small comments to address.

Also, you should add your name to the line:

f.contributors = 'Albert Lunde, Asmus Freytag, Björn Höhrmann, Henri Sivonen, John Cowan, Leif Halvard Silli, Norbert Lindenberg' // people providing useful contributions or feedback during review or at other times

And the corresponding line for the english version of the RTL scripts article.

@clavoline
Copy link
Contributor Author

Thank you @r12a, I've made those changes.

In the Further Reading section, I thought it best to revert to the original format :)

@r12a
Copy link
Contributor

r12a commented Jul 28, 2023

Ok, @clavoline i have reviewed both articles and the changes proposed for the original English version, and all looks good.

If you're ready for me to publish and announce these, let me know.

@clavoline
Copy link
Contributor Author

Thank you @r12a, I think we're done.

I don't expect to complete the third translation soon, so there's no reason to wait!

@r12a r12a merged commit a615280 into w3c:gh-pages Jul 28, 2023
5 checks passed
@r12a
Copy link
Contributor

r12a commented Jul 28, 2023

Published and announced (see https://w3c.social/@webi18n/110791285730549570 and https://twitter.com/webi18n/status/1684877263211507712).

Thanks again !

@clavoline
Copy link
Contributor Author

clavoline commented Jul 28, 2023 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants