Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translate bidi-xhtml into zh-hans #513

Merged
merged 9 commits into from
Sep 5, 2023
Merged

Conversation

xfq
Copy link
Member

@xfq xfq commented Aug 8, 2023

@xfq xfq requested a review from r12a August 8, 2023 05:51
@netlify
Copy link

netlify bot commented Aug 8, 2023

Deploy Preview for i18n-drafts ready!

Name Link
🔨 Latest commit 62300fa
🔍 Latest deploy log https://app.netlify.com/sites/i18n-drafts/deploys/64f5a4f5222f360007ee86e1
😎 Deploy Preview https://deploy-preview-513--i18n-drafts.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@@ -67,7 +67,6 @@ <h2 class="notoc">Objectives</h2>


<div id="audience">
<p><span id="intendedAudience" class="leadin">Intended audience:</span> HTML/XHTML and CSS content authors implementing pages in right-to-left scripts such as Arabic and Hebrew, or having to deal with embedded right-to-left script text. This material is applicable whether you create documents in an editor, or via scripting.</p>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know we have been removing this at the top of articles, but i left it in place for the tutorials because it's common practice to describe the intended audience for a tutorial or training session.

We should mention who should read this somewhere. We could either leave the text in place, or we could add a paragraph to the introduction.

It may be good, however, to remove "/XHTML". I think the final sentence can also go (ie. This material is applicable...).

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fair enough. I added it back. Thanks.

@r12a
Copy link
Contributor

r12a commented Aug 8, 2023

The links are not very obvious. I think it may help to add the following style for the tutorials:

.maintitle {
  font-size: 1.2em;
}

tutorials/bidi-xhtml/index.zh-hans.html Outdated Show resolved Hide resolved
@xfq xfq requested a review from r12a September 4, 2023 09:36
@xfq xfq merged commit 64cbe77 into gh-pages Sep 5, 2023
5 checks passed
@xfq xfq deleted the xfq/tutorials/bidi-xhtml-zh-hans branch September 5, 2023 05:27
@xfq
Copy link
Member Author

xfq commented Sep 5, 2023

Merging. Copied to CVS as well, including the updated style/article-2022.css file.

Thank you very much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants