Language tags French t9n update #557
Conversation
✅ Deploy Preview for i18n-drafts ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
hi @clavoline it took me a while to finish reviewing this because there are many differences in the way you arranged the text, but i think it looks ok, with one small exception (compared with the proposed new english version). The note just below the top heading doesn't follow our current style. You need to change the class from Otherwise, i think we're good. Thanks. |
|
@r12a Thank you. Sorry I missed that one! |
|
Ah, that didn't quite work. I think we need to replace the |
|
Looks good. Happy for me to publish and announce it ? |
|
@r12a Of course, if you're happy with it! |
|
For the record, i had to fix a number of validation errors, and put section tags around all the new section headings (with ids). The diff can be seen at b026502 |
|
@r12a My apologies - I forgot about the translation checklist and didn't realize sections were also required for H3s. |
|
np @clavoline I just pointed to it so that you are aware for next time :-) All announced now. |
|
@clavoline we have some feedback on mastodon, suggesting that étiquettes should be balises. Do you think we should change it? https://w3c.social/@webi18n/111341218907831498 |
|
I think balise refers to markup tags, rather than language tags?? |
Agreed. This is one of the first questions I asked myself! These 3 sources use "étiquettes": |
@r12a Submitting the changes again because I think I got it wrong the first time, sorry!