Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dur003 tests need available render time of 0.5 to be selective #9

Closed
nigelmegitt opened this issue Dec 4, 2023 · 0 comments · Fixed by #10
Closed

dur003 tests need available render time of 0.5 to be selective #9

nigelmegitt opened this issue Dec 4, 2023 · 0 comments · Fixed by #10

Comments

@nigelmegitt
Copy link
Contributor

The dur003-fail test is now valid. Looking back through the history, it used to have a <p> element not associated with any region, with begin="2.5s". We removed that in 30f48ae and doing so should have made no difference, because that content should have been pruned, resulting in an empty ISD. However, before that element was removed, the sandflow/imscHRM implementation failed validation on that test because it had (wrongly) computed the available render time as 0.5s.

Indeed the render time of the ISD beginning at 3s in dur003-fail should compute to just over 0.5s, and that of dur003-pass to less than 0.5s.

I propose to add back the <p begin="2.5s"... to change the available render time back to 0.5s, in both dur003 tests so that they have the expected behaviours.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant