Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No text visible and spurious tts:extent in DisplayAlign00X #20

Closed
palemieux opened this issue Jun 15, 2017 · 3 comments
Closed

No text visible and spurious tts:extent in DisplayAlign00X #20

palemieux opened this issue Jun 15, 2017 · 3 comments
Assignees
@palemieux
Labels
enhancement PR open

Comments

@palemieux
Copy link
Contributor

palemieux commented Jun 15, 2017 •
edited
Loading

The initial value of tts:color is white, which makes the text unreadable since tts:backgroundColor="white", and tts:extent="200px 170px" is overridden by tts:extent="100% 100%".

Proposal:

  • set tts:backgroundColor="black" on the region
  • remove <style tts:extent="200px 170px"/>
  • replace tts:extent="100% 100%" with tts:extent="200px 170px"
@palemieux palemieux self-assigned this Jun 15, 2017
@mikedo
Copy link

mikedo commented Jun 15, 2017

"green" -> "lime" on par with the other full luminance color names used.

@palemieux
Copy link
Contributor Author

"green" -> "lime" on par with the other full luminance color names used.

"lime" is too bright for a background if the text is "white".

Changed to "black"

@palemieux palemieux assigned palemieux and unassigned palemieux Jun 17, 2017
@palemieux
Copy link
Contributor Author

replace tts:extent="100% 100%" with tts:extent="200px 170px"

tts:extent="100% 100%" should be kept since no px measures are used

@palemieux palemieux mentioned this issue Jul 18, 2017
Merged
palemieux added a commit that referenced this issue Aug 1, 2017
@palemieux
Generic improvements to tests
64e9a8f 
Fixes #9, #10, #11, #13, #14, #15, #16,  #17, #18, #20, #21, #22, #23, #24, #27, #28, #29, #30, #31, #32, #33, #34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@palemieux palemieux

Labels
enhancement PR open
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mikedo @palemieux