Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why is display align not permitted in image profile? #118

Closed
skynavga opened this issue Dec 8, 2015 · 13 comments
Closed

Why is display align not permitted in image profile? #118

skynavga opened this issue Dec 8, 2015 · 13 comments
Assignees
Milestone

Comments

@skynavga
Copy link
Contributor

skynavga commented Dec 8, 2015

Display align is allowed in text, but not in image profile. Why? It has as much applicability in the latter as the former.

@nigelmegitt
Copy link
Contributor

My understanding of this is that since the images must be sized identically to the regions display align would have no effect.

@skynavga
Copy link
Contributor Author

skynavga commented Dec 8, 2015

I had been looking for that text (late) last night but didn't find it, but
I see it now. That raises the issue of why multiple divs are allowed in a
region.

On Tue, Dec 8, 2015 at 4:09 AM, nigelmegitt notifications@github.com
wrote:

My understanding of this is that since the images must be sized
identically to the regions display align would have no effect.


Reply to this email directly or view it on GitHub
#118 (comment).

@nigelmegitt
Copy link
Contributor

It seems reasonable to permit a region to have multiple child divs that do not temporally overlap.

@skynavga
Copy link
Contributor Author

skynavga commented Dec 8, 2015

True, but there is no constraint (at present) on the presence of multiple
divs in a regiion in a single ISD.

On Tue, Dec 8, 2015 at 9:08 AM, nigelmegitt notifications@github.com
wrote:

It seems reasonable to permit a region to have multiple child divs that do
not temporally overlap.


Reply to this email directly or view it on GitHub
#118 (comment).

@nigelmegitt
Copy link
Contributor

That does seem to be a bug.

@palemieux
Copy link
Contributor

See Section 8.2 at https://rawgit.com/w3c/imsc/issue-97/spec/ttml-ww-profiles.html

There is at most at most one presented image per presented region.

@skynavga
Copy link
Contributor Author

But that doesn't prevent two divs from being assigned to a region in the
same ISD, both having a background image. There should be a constraint of
one div per region in a given ISD.

On Wed, Dec 9, 2015 at 4:09 PM, Pierre-Anthony Lemieux <
notifications@github.com> wrote:

See Section 8.2 at
https://rawgit.com/w3c/imsc/issue-97/spec/ttml-ww-profiles.html

There is at most at most one presented image per presented region.


Reply to this email directly or view it on GitHub
#118 (comment).

@palemieux
Copy link
Contributor

How would two div elements, both with a background image and both flowed into the same region in the same ISD, not contradict the restriction that There is at most at most one presented image per presented region?

The intent is for a single div with background image per region in a given ISD. I do not claim that the current text is not broken, but would like to understand why.

@skynavga
Copy link
Contributor Author

On Wed, Dec 9, 2015 at 6:33 PM, Pierre-Anthony Lemieux <
notifications@github.com> wrote:

How would two div elements, both with a background image and both flowed
into the same region in the same ISD, not contradict the restriction that There
is at most at most one presented image per presented region
?

The intent is for a single div with background image per region in a given
ISD. I do not claim that the current text is not broken, but would like to
understand why.

A second div could have no background image, or it could have an image that
overflows the region.

I question the manner in which you expressed the original constraint: in
terms of one presented image.

I would have simply required no more than one div.


Reply to this email directly or view it on GitHub
#118 (comment).

@palemieux
Copy link
Contributor

Thanks for clarifying

@palemieux
Copy link
Contributor

What are the dimensions of a div that contains no content?

@skynavga
Copy link
Contributor Author

As you might expect, [0,0], but as I said, one could have two divs, each
with background image, one of which is presented, and which image geometry
matches region geometry, and a second (third etc) with a background image
which overflows the region (and if overflow is hidden) then is not
presented (and thus satisfies your no more than one presented image
constraint).

On Wed, Dec 9, 2015 at 6:53 PM, Pierre-Anthony Lemieux <
notifications@github.com> wrote:

What are the dimensions of a div that contains no content?


Reply to this email directly or view it on GitHub
#118 (comment).

@palemieux
Copy link
Contributor

The pull requests #123 constrains the number of div elements to at most one in presented regions.

@palemieux palemieux added this to the imsc1-cr3 milestone Dec 15, 2015
@palemieux palemieux self-assigned this Dec 15, 2015
palemieux added a commit that referenced this issue Dec 17, 2015
Resolves #118 (Constrains the number of div elements in Image Profile)
Accepted per 20151217 meeting
@palemieux palemieux removed the pr open label Jan 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants