-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Testsuite tests missing recommended ttp:profile attribute #130
Comments
I have changed the label to "enhancement" since ttp:profile is not required, merely strongly recommended. As with #133, I would rather not risk changing the test suite at this point of the process unless absolutely required. I suggest discussing this at an upcoming TTWG telecon. |
Please provide a technical reason that this change presents a risk. All On Fri, Jan 15, 2016 at 12:11 AM, Pierre-Anthony Lemieux <
|
Also, it seems bad form to write tests that produce warnings in TTV when On Fri, Jan 15, 2016 at 1:17 AM, Glenn Adams glenn@skynav.com wrote:
|
This is really about risk management: any substantive change at this point of the process may have unintended consequences (see recent prohibition of ttp:profile element). Instead I suggest that we:
|
I insist on fixing in IMSC1. We can discuss in upcoming telecons. |
[not facetious]: isn't it a good thing that you can verify that TTV generates a warning when a recommendation is not followed? Modifying the test suite at this late stage where there is no actual conformance issue carries the risk that existing implementations that currently pass the test fail it after the change has been made. Clearly that would be an indication that the implementation is not behaving correctly, but that's not our primary concern right now from the perspective of moving to Proposed Recommendation. To reduce this risk can we address this by:
Would that be an acceptable way forward? Let's discuss in today's meeting if possible. |
I can only agree to a solution that entails fixing all warnings in the test The only risk in not doing this change is that some existing implementation On Thu, Jan 21, 2016 at 4:48 AM, nigelmegitt notifications@github.com
|
I restored the bug label because I believe it is a bug to have a test produce a warning unless it is the express intent of the test to verify the production of the warning. |
Notes from today's TTWG meeting: the view is to update all tests so that they do not generate warnings from processors that check for conformance with specification recommendations, unless the specific goal of the test is to check that such warnings are issued when they apply. |
All of the TTML files in the test suite should specify a ttp:profile attribute to satisfy the recommendation that a ttp:profile attribute SHOULD be specified (if not an EBU-TT-D document).
The text was updated successfully, but these errors were encountered: