Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Example of documents that fail the HRM #71

Closed
plehegar opened this issue Nov 4, 2015 · 3 comments
Closed

Example of documents that fail the HRM #71

plehegar opened this issue Nov 4, 2015 · 3 comments
Assignees
@palemieux
Labels
enhancement imsc1.1

Comments

@plehegar
Copy link
Member

plehegar commented Nov 4, 2015

Needs description (and possibly an example) of a document (for each profile) that would result in an HRM error given the default parameter values.

(raised by Glenn Adams on 2015-09-21)
From tracker issue http://www.w3.org/AudioVideo/TT/tracker/issues/431
@plehegar plehegar added the imsc1 label Nov 4, 2015
@palemieux palemieux removed the imsc1 label Nov 7, 2015
@palemieux palemieux added this to the imsc1 milestone Nov 7, 2015
@palemieux palemieux removed this from the imsc1-cr3 milestone Dec 17, 2015
@palemieux palemieux modified the milestone: imsc2 Feb 11, 2016
@palemieux palemieux removed this from the imsc2 milestone Sep 28, 2017
@palemieux
Copy link
Contributor

Below is a document that fails the HRM between the second and third ISD. Specifically, according to my calculations,

DUR(E2) = S(E2) / BDraw + DURT(E2) = 0.07

since

S(E2) = PAINT(E2) = NSIZE(R1) ∙ NBG(R1) = 1600*200/1920/1080 ∙ 2 = 0.31

and

DURT(E2) = 26 ∙ NRGA / Ren = 26 ∙ (50/1080)**2/ 1.2 = 0.046

Therefore DUR(E2) is smaller than the presentation time of E1, which is 0.05s, and the HRM fails.

<?xml version='1.0' encoding='UTF-8'?>
<tt  xmlns:ittp="http://www.w3.org/ns/ttml/profile/imsc1#parameter" xmlns:tts="http://www.w3.org/ns/ttml#styling" xmlns:ttp="http://www.w3.org/ns/ttml#parameter" xmlns="http://www.w3.org/ns/ttml" xml:lang="en" tts:extent="1920px 1080px" ttp:profile="http://www.w3.org/ns/ttml/profile/imsc1/text">
  <head>
    <styling>
      <style xml:id="s1" tts:backgroundColor="blue" />
    </styling>
    <layout>
      <region xml:id="r1" tts:origin="100px 780px" tts:extent="1600px 200px" tts:color="white" tts:backgroundColor="black" tts:padding="5px 5px" tts:opacity="0.85" tts:textAlign="center" tts:showBackground="whenActive" tts:lineHeight="100%" tts:color="white"  tts:fontFamily="proportionalSansSerif" tts:fontSize="50px" tts:textAlign="left"/> 
    </layout>
  </head>
  <body>

    <div >
      <p region="r1" begin="0s" end="0.1s" style="s1">ABCDEFGHIJKLMNOPQRSTUVWXYZ</p>
      <p region="r1" begin="0.1s" end="0.15s" style="s1">abcdefghijklmnopqrstuvwxyz</p>
      <p region="r1" begin="0.15s" end="0.25s" style="s1">ABCDEFGHIJKLMNOPQRSTUVWXYZ</p>
    </div>

  </body>
</tt>

@palemieux
Copy link
Contributor

I think it is more instructive to provide an example that achieves the HRM limit, as suggested at w3c/imsc-tests#37

@palemieux palemieux self-assigned this Nov 2, 2017
@css-meeting-bot
Copy link
Member

The Working Group just discussed Example of documents that fail the HRM #71, and agreed to the following resolutions:

  • RESOLUTION: Close this issue, in favour of adding threshold and fail tests to imsc-tests.
The full IRC log of that discussion <nigel> Topic: Example of documents that fail the HRM #71
<nigel> github: https://github.com//issues/71
<nigel> Pierre: I've added an example that fails. But as a stylistic issue I don't like to put failing
<nigel> .. examples in specifications. I'd rather add something to the IMSC test suite that provides
<nigel> .. documents at the threshold of the HRM. My inclination is to close this issue and add to
<nigel> .. the imsc-tests suite documents ones that are at the threshold. I think that achieves the
<nigel> .. same objective, first providing a test to check that implementations meet the HRM requirements,
<nigel> .. and secondly allowing people to check they have the same understanding of the HRM.
<nigel> Glenn: I have a different opinion philosophically - counter examples are an important part
<nigel> .. of any formal specification. So I think it's very useful to have official counter-examples.
<nigel> Pierre: Maybe in the test suite.
<nigel> Nigel: In the test suite it is a positive test for a validating processor that it should reject
<nigel> .. documents that do not pass the HRM test.
<nigel> Pierre: I'm concerned about spec readers assuming that the document is a good one even
<nigel> .. though it is a bad one.
<nigel> .. In the test suite we could have both documents that fail and documents that are on the threshold.
<nigel> Glenn: And you might put the failures in a separate folder.
<nigel> Pierre: Definitely!
<nigel> .. My proposal is to close this issue.
<nigel> Nigel: Is it okay by you Glenn to have this in tests only?
<nigel> Glenn: Yes
<nigel> Cyril: Agreed
<nigel> RESOLUTION: Close this issue, in favour of adding threshold and fail tests to imsc-tests.

@css-meeting-bot css-meeting-bot mentioned this issue Nov 2, 2017
Open
@palemieux palemieux removed the pr open label Jan 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@palemieux palemieux

Labels
enhancement imsc1.1
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@plehegar @palemieux @css-meeting-bot