Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address #133 (missing tts:lineHeight with value not 'normal') #143

Closed
wants to merge 2 commits into from

Conversation

skynavga
Copy link
Contributor

No description provided.

@nigelmegitt
Copy link
Contributor

I'm curious: why put the tts:lineHeight attribute on body rather than region? They seem to be identical in terms of processing, but having tts:lineHeight on region would look tidier given that's where all the other style attributes are set. I suppose it avoids having to add the same tts:lineHeight attribute on all the regions when there are several in the same document instance.

@skynavga
Copy link
Contributor Author

Yes, it was because by putting it on body, it would cover all content in
multiple regions. If this were TTML2, we would have other options as well,
such as putting on tt or adding an initial element, in which case I would
likely use the latter (initial).

On Fri, Jan 29, 2016 at 4:31 AM, nigelmegitt notifications@github.com
wrote:

I'm curious: why put the tts:lineHeight attribute on body rather than
region? They seem to be identical in terms of processing, but having
tts:lineHeight on region would look tidier given that's where all the
other style attributes are set. I suppose it avoids having to add the same
tts:lineHeight attribute on all the regions when there are several in the
same document instance.


Reply to this email directly or view it on GitHub
#143 (comment).

@skynavga skynavga closed this Jan 31, 2016
@palemieux palemieux deleted the issue-133 branch February 3, 2016 22:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants