Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarify that the concrete encoding uses XML 1.0 #438

Merged
merged 3 commits into from Jul 17, 2018
Merged

Clarify that the concrete encoding uses XML 1.0 #438

merged 3 commits into from Jul 17, 2018

Conversation

palemieux
Copy link
Contributor

Closes #431

@palemieux palemieux added this to the imsc1.1 CR2 milestone Jul 14, 2018
@palemieux palemieux self-assigned this Jul 14, 2018
nigelmegitt
nigelmegitt reviewed Jul 16, 2018
View reviewed changes
imsc1/spec/ttml-ww-profiles.html Outdated
@@ -2052,7 +2051,8 @@ <h2>Common Provisions</h2>
<section>
<h3>Document Encoding</h3>

<p>A <a>Document Instance</a> SHALL use UTF-8 character encoding as specified in [[!UNICODE]].</p>
<p>A <a>Document Instance</a> SHALL be concretely encoded as a well-formed XML 1.0 [[!XML 1.0]] document using the UTF-8
character encoding as specified in [[!UNICODE]].</p>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apologies I didn't put this in the issue, but as per TTML2 appendix P.1 I think we should also add an "and SHALL not use entity expansion" statement here.

nigelmegitt
nigelmegitt approved these changes Jul 17, 2018
View reviewed changes
Copy link
Contributor

@nigelmegitt nigelmegitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is fair given how recently it has been raised. It occurs to me that validation processors that are based on XML bindings etc may not have API access to the unexpanded entities, so it may not be straightforward to implement.

nigelmegitt
nigelmegitt requested changes Jul 17, 2018
View reviewed changes
Copy link
Contributor

@nigelmegitt nigelmegitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just noticed the [[!XML 1.0]] references aren't being processed correctly by respec. Not sure if they're well formed.

nigelmegitt
nigelmegitt approved these changes Jul 17, 2018
View reviewed changes
Copy link
Contributor

@nigelmegitt nigelmegitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Having fixed the XML 1.0 references, this now looks good to me, as per previous review comment.

@palemieux palemieux mentioned this pull request Jul 17, 2018
Closed
@palemieux palemieux merged commit b4d6a22 into master Jul 17, 2018
@palemieux palemieux deleted the issue-431-concrete-encoding branch July 17, 2018 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nigelmegitt nigelmegitt nigelmegitt approved these changes

Assignees

@palemieux palemieux

Labels
imsc1.1
Projects
None yet
Milestone
imsc1.1 CR2
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@palemieux @nigelmegitt