Added informative note on using tts:shear instead of italic #514
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dkneeland Please review |
cconcolato
requested changes
Dec 6, 2019
There was a problem hiding this comment.
The current text hints that oblique or shear are the same. I would have written the note a bit differently along the lines of:
"Because italic versions often don't exist for Japanese fonts, and because 'italicized' vertical text behaves differently from horizontal text, it is recommended to use tts:shear for Japanese text instead of tts:fontStyle='italic' or tts:fontStyle='oblique'.
|
I agree with Cyril's above recommendation. |
|
@cconcolato and @dkneeland See revised text. |
|
I think that's fine, but I would be interested to hear feedback from @cconcolato as well. |
|
@cconcolato Did you have a chance to review the changes in response to your request? |
cconcolato
approved these changes
Dec 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #495
Preview | Diff