Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

List non-editorial fixes for JLReq 2nd ed errata release #149

Closed
himorin opened this issue Dec 5, 2019 · 4 comments
Closed

List non-editorial fixes for JLReq 2nd ed errata release #149

himorin opened this issue Dec 5, 2019 · 4 comments
Assignees

Comments

@himorin
Copy link
Contributor

himorin commented Dec 5, 2019

from #141

Last item for publication (?), we need to build revision log of this update.

tentative list:

  • Ruby placement procedure updated with merging 3.3.8 f,g,h into one item (issue 15, PR 44)
  • Wording fixes (issue 10, PR 66; issue 67, PR 82; issue 85, PR 91;
  • Merging English and Japanese version (7dcc927 etc. for main; PR 88 for glossary table)
  • Updated English text for inaccurate translation (issue 84, PR 128; issue 127, PR 129)
@himorin himorin self-assigned this Dec 5, 2019
@kidayasuo
Copy link
Contributor

Is it correct that it is a complete list (minus unimportant changes) because you built it from the list of all GitHub issues / PR that are fixed in this release?
Are there issues that you want to discuss, e.g. are there ones that on the border weather we should mention?

@himorin
Copy link
Contributor Author

himorin commented Dec 12, 2019

Is it correct that it is a complete list (minus unimportant changes) because you built it from the list of all GitHub issues / PR that are fixed in this release?

I believe yes.
Not listing editorial fixes for merging and minor editorial fixes for English and images.

@himorin
Copy link
Contributor Author

himorin commented Dec 13, 2019

from F2F Dec 13, 2019, we decided to list first three items.

@himorin
Copy link
Contributor Author

himorin commented Jun 8, 2020

closing this, PR #157 merged.

@himorin himorin closed this as completed Jun 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants