Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update expat #7

Closed
wants to merge 1 commit into from
Closed

Conversation

sideshowbarker
Copy link

@sideshowbarker sideshowbarker commented Jun 21, 2017

This change updates expat to the latest sources from the master branch at
https://github.com/libexpat/libexpat

Fixes #6

After this change, libwww still builds successfully in my environment, but I
don’t know if/how to test to make sure nothing has regressed...

This change updates expat to the latest sources from the master branch at
https://github.com/libexpat/libexpat

Fixes #6
@jkbzh
Copy link
Contributor

jkbzh commented Jun 21, 2017

Hi @sideshowbarker ,

Thanks for your PR. There is only one issue: you commited both the source code.. and binaries of expat. Could you do a make clean and then either a new PR or remove the binary files from the previous one so that only the pre-compile/pre-configuration source code is commited?

Thanks!

@hartwork
Copy link

hartwork commented Jun 21, 2017

If aim you at the Expat tarball file list for the modules/expat folder, this is the list of file additions/removals I would expect. It's that many because we dropped a few ancient build systems:

# diff -u0 <(tar tf expat-2.2.0.tar.bz2 | sed 's,^expat-2.2.0/,,' | sort) <(tar tf expat-2.2.1.tar.bz2 | sed 's,^expat-2.2.1/,,' | sort) | grep -v '@@'
--- /dev/fd/63  2017-06-21 16:50:33.711407462 +0200
+++ /dev/fd/62  2017-06-21 16:50:33.712407464 +0200
-amiga/
-amiga/expat_68k.c
-amiga/expat_68k.h
-amiga/expat_68k_handler_stubs.c
-amiga/expat_base.h
-amiga/expat_lib.c
-amiga/expat_vectors.c
-amiga/expat.xml
-amiga/include/
-amiga/include/inline4/
-amiga/include/inline4/expat.h
-amiga/include/interfaces/
-amiga/include/interfaces/expat.h
-amiga/include/libraries/
-amiga/include/libraries/expat.h
-amiga/include/proto/
-amiga/include/proto/expat.h
-amiga/launch.c
-amiga/Makefile
-amiga/README.txt
-bcb5/
-bcb5/all_projects.bpg
-bcb5/elements.bpf
-bcb5/elements.bpr
-bcb5/elements.mak
-bcb5/expat.bpf
-bcb5/expat.bpr
-bcb5/expat.mak
-bcb5/expat_static.bpf
-bcb5/expat_static.bpr
-bcb5/expat_static.mak
-bcb5/expatw.bpf
-bcb5/expatw.bpr
-bcb5/expatw.mak
-bcb5/expatw_static.bpf
-bcb5/expatw_static.bpr
-bcb5/expatw_static.mak
-bcb5/libexpat_mtd.def
-bcb5/libexpatw_mtd.def
-bcb5/makefile.mak
-bcb5/outline.bpf
-bcb5/outline.bpr
-bcb5/outline.mak
-bcb5/README.txt
-bcb5/setup.bat
-bcb5/xmlwf.bpf
-bcb5/xmlwf.bpr
-bcb5/xmlwf.mak
+AUTHORS
-examples/elements.dsp
-examples/outline.dsp
-expat.dsw
-lib/amigaconfig.h
-lib/expat.dsp
-lib/expat_static.dsp
-lib/expatw.dsp
-lib/expatw_static.dsp
-lib/macconfig.h
-lib/Makefile.MPW
+lib/siphash.h
+run.sh.in
-tests/benchmark/benchmark.dsp
-tests/benchmark/benchmark.dsw
+tests/memcheck.c
+tests/memcheck.h
-vms/
-vms/descrip.mms
-vms/expat_config.h
-vms/README.vms
-xmlwf/xmlwf.dsp

Best, Sebastian

PS: Note to self: libwww is using nested configure with libwww (AC_CONFIG_SUBDIRS).

@sideshowbarker
Copy link
Author

Closing thing in favor of #8.

@sideshowbarker sideshowbarker deleted the sideshowbarker/expat-update branch June 22, 2017 00:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants