Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

file variant with region in language tag #12

Open
wants to merge 2 commits into
base: gh-pages
Choose a base branch
from

Conversation

ericprud
Copy link
Member

@ericprud ericprud commented Sep 22, 2021

I'm assuming this is permitted/expected but not sure. This PR is my way of asking the question.


Preview | Diff

I'm assuming this is permitted/expected but not sure. This PR is my way of asking the question.
@aphillips
Copy link
Contributor

@ericprud Thanks for the PR. Yes, other subtags can be used. It is probably a gap in the document that I don't discuss locale-based fallback mechanisms. This deserves more text.

Your PR is sort-of correct from the point of view that there could be an fr-CA file. The language tag inside the file probably wants to match the filename (e.g. "language": "fr-CA" too).

I'll prepare some text/examples to address.

@ericprud
Copy link
Member Author

ericprud commented Sep 23, 2021

Tx. I've updated the PR, but feel free to close at your discretion.

@aphillips pointed out that i'd missed the region in the `language'
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants