Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify Possible "Task Types" #40

Closed
tdresser opened this issue Feb 1, 2018 · 8 comments
Closed

Specify Possible "Task Types" #40

tdresser opened this issue Feb 1, 2018 · 8 comments
Assignees

Comments

@tdresser
Copy link
Contributor

tdresser commented Feb 1, 2018

In order to provide attribution, we need a common notion of task types.

Let's come up with a proposal for a set of task types all UA's can agree on.

In the short term:

  • Don't name them script

Strawman: provide attribution for:

  • Render steps
  • Other browser work
  • Posted tasks
@tdresser
Copy link
Contributor Author

tdresser commented Feb 1, 2018

@npm1

@maxlgu
Copy link

maxlgu commented May 16, 2018

Ping from crbug.com/759166 as it's getting stale.

@npm1
Copy link
Contributor

npm1 commented May 16, 2018

We need to add some clarifications/fixes to the current API before we can consider extending it.

@npm1
Copy link
Contributor

npm1 commented Oct 25, 2018

Discussed at TPAC. The resolution was that it's unclear what the classification should be. In particular, coarseness is tricky because if we want to start with a coarse classification and then make it more granular, that results in confusing metrics. For now, we're punting this for an indefinite amount of time.

@igrigorik
Copy link
Member

Any reason why we shouldn't close this?

@npm1
Copy link
Contributor

npm1 commented Oct 25, 2018

I was going to say no reason but I see that I already landed into the spec the 'rendering' and 'browser' possibilities into the |name| attribute of PerformanceLongTaskTiming. Should we roll this back so we don't have any kind of task types specified? Chrome has not implemented this yet.

I'd argue that task types of the future would be specified in a separate attribute (|name| already includes script origin information), so the granularity concern is not valid in this case. That is, if and when we add more task types, they will be added to a new attribute, so the granularity of |name| shall be unaffected.

@tdresser
Copy link
Contributor Author

Rolling that spec change back and closing this issue is probably reasonable.

npm1 added a commit that referenced this issue Nov 20, 2018
From TPAC discussions, we decided to not provide "rendering" and "browser" types for now. The task attribution improvement is delayed until we have a good idea of what types of tasks we should be exposing which developers would find useful. The fear here is that exposing types incrementally could be confusing to developers. This change "fixes" #40

No test changes required because I had not updated tests for this. Will followup by changing the caller of the Report long task algorithm in HTML spec (removing the |type| parameter).
domenic pushed a commit that referenced this issue Nov 20, 2018
From TPAC discussions, we decided to not provide "rendering" and "browser" types for now. The task attribution improvement is delayed until we have a good idea of what types of tasks we should be exposing which developers would find useful. The fear here is that exposing types incrementally could be confusing to developers. This change "fixes" #40

No test changes required because I had not updated tests for this. Will followup by changing the caller of the Report long task algorithm in HTML spec (removing the |type| parameter).
@domenic
Copy link
Contributor

domenic commented Nov 20, 2018

Closed by #50, thanks @npm!

@domenic domenic closed this as completed Nov 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants