Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't talk about "frames" #46

Closed
domenic opened this issue Aug 28, 2018 · 0 comments
Closed

Don't talk about "frames" #46

domenic opened this issue Aug 28, 2018 · 0 comments
Labels
editorial

Comments

@domenic
Copy link
Contributor

domenic commented Aug 28, 2018

This spec defines

Frame or frame context refers to the browsing context, such as iframe (not animation frame), embed or object in which some work (such as script or layout) occurs.

But never officially refers to these terms. It does say "frame" and "frame tree" a lot though.

But, it's a bad idea to bring this Blink-specific terminology into the spec land. Just use "browsing context".
@npm1 npm1 added the editorial label Oct 17, 2018
domenic added a commit that referenced this issue Nov 20, 2018
@domenic
Many fixes, both substantive and editorial
d04d4f2 
Substantive:

- Actually specified when "self", "same-origin", and "cross-origin-unreachable" apply
- Specified where containerType is set to "iframe"; previously it was left unset

Editorial:

- Properly have the processing model be the source of truth for setting attribute values. Related to (but does not completely solve) #11.
- Remove mention of "frames" in favor of browsing contexts. Closes #46.
- Standardized on sentence-case headings
- Lots more cross-linking (relatedly, only defined terms that we use)
@domenic domenic mentioned this issue Nov 20, 2018
Merged
@npm1 npm1 closed this as completed in #51 Nov 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
editorial
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@domenic @npm1