Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional edits for flow, style, and consistency #21

Merged
merged 2 commits into from Sep 28, 2020

Conversation

aphillips
Copy link
Contributor

@aphillips aphillips commented Sep 27, 2020

Minor textual edits to definitions for Locale, Unicode Locale, and the locale-netural example. I slightly tweaked @fsasaki's text where my previous suggestion made the text repetitive.


Preview | Diff

@xfq
Copy link
Member

xfq commented Sep 28, 2020

Looks good to me.

@fsasaki
Copy link
Collaborator

fsasaki commented Sep 28, 2020

Here are some commments:

  1. Not part of this pull request, but the link to CLDR
    https://cldr.unicode.org/
    from the "references" section does not work for me. http://cldr.unicode.org/ works (although HTTPS would be better).
  2. Reference to CLDR as a source for locale processing rules, e.g. here:
    "A language tag that follows the additional processing rules defined by [CLDR]"
    Is there a list of the locale processing rules available, e.g. as part of LDML? Pointing to such a list would be helpful for users & implementers of CLDR. If there is no such list, maybe put it into the LTLI document?

The rest of the pull request looks good to me. You may also want to merge the pull request and address these comments in a new pull request.

@aphillips
Copy link
Contributor Author

@fsasaki

On (1), yikes! You're correct. I guess I just assumed Unicode had moved to https.

On (2), I agree. The rules and such are here and I'll add the link to our doc.

@aphillips
Copy link
Contributor Author

Ugh. You're all officially going to hate me.

I'm going to merge this now, because in the course of addressing @fsasaki's #2, I ended up doing a fairly significant reorg.

@aphillips aphillips merged commit baaff03 into w3c:gh-pages Sep 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants