Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editorial pass, update informative references, fix broken links #47

Merged
merged 2 commits into from Mar 15, 2018

Conversation

anssiko
Copy link
Member

@anssiko anssiko commented Mar 14, 2018


Preview | Diff

- Editorial Use Cases and Requirements update, remove RFC 2119 terms, s/earth/Earth/g
- Avoid redundant redirects:
  https://w3c.github.io/sensors -> https://w3c.github.io/sensors/
  https://w3c.github.io/accelerometer -> https://w3c.github.io/accelerometer/
- Fix Broken fragments:
  https://w3c.github.io/sensors#sensor-readings
- Reduce informative references to scientific papers
- Explicitly note "This section is non-normative" in:
  Use Cases and Requirements
  Compass Heading Using Magnetometers
@anssiko anssiko requested a review from riju March 14, 2018 16:10
Copy link
Contributor

@riju riju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍
I left some nits.

index.bs Outdated
- In cases, where it is not possible to use orientation sensor, user may need to fuse magnetometer data with with other low-level sensor data, to calculate orientation.
- Indoor navigation system may use magnetometer on mobile phones [[MAGINDOORPOS]]. Specific use cases for indoor navigation may include proximity advertising, way finding in malls or airports, geofencing, etc.
- Calculating compass heading, more on that in [[#compass]].
- A common use-case for magnetometers is sensor fusion in order to generate an Orientation Sensor which is stationary to the Earth plane, or a compass, which is basically the former with corrections to the declination depending on geolocation position, such that it points to the true north.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you want to link to the Orientation Sensor spec (https://www.w3.org/TR/orientation-sensor/) , AbsoluteOrientationSensor to be specific, denoting that if sensor hub/hardware is unable to provide us and we use sensor fusion ourselves.

@anssiko
Copy link
Member Author

anssiko commented Mar 15, 2018

@riju, thanks for the review! I addressed your comments in 94c48ff PTAL.

Copy link
Contributor

@riju riju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

index.bs Outdated
Head mount tracking in Virtual Reality may require sensor fusion from accelerometer, gyroscope and magnetometer. Magnetometer data may be used to help in calibration of gyroscope readings
and align yaw readings with the magnetic north. The required sampling rate might depend on the sensor fusion algorithm and characteristics of other motion sensors involved.
<div class="note">
Requirements with respect to data coasrceness and sampling frequency can vary depending on the use case at hand. For example, metal detection or input using magnetic button can likely be implemented with coarser data and using lower sampling frequency compared to gesture recognition, indoor navigation, or VR and AR use cases. In sensor fusion use cases, the sampling frequency that yeilds optimal results is dependent on e.g. sensor fusion algorithm and characteristics of other motion sensors involved.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

coarseness

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FIxed, PR updated.

- Add informative reference: Absolute Orientation Sensor [MOTION-SENSORS]
- Reorder use cases
- Editorial updates
@riju riju merged commit 5033fac into gh-pages Mar 15, 2018
@anssiko anssiko deleted the editorial branch March 15, 2018 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants