-
Notifications
You must be signed in to change notification settings - Fork 159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
start_url should not default to document URL #669
Comments
No a big fan of making it mandatory... will chew on it. |
OK I renamed the title since there isn't consensus on what the solution is (but I think we agree on the problem). I've uploaded a patch at #670. There are issues with making |
Note: Can't just delete MIME type registration for .webmanifest file. Closes w3c#669.
Note: Can't just delete MIME type registration for .webmanifest file. Closes w3c#669.
Note: Can't just delete MIME type registration for .webmanifest file. Closes w3c#669.
Note: Can't just delete MIME type registration for .webmanifest file. Closes w3c#669.
Note: Can't just delete MIME type registration for .webmanifest file. Closes w3c#669.
Note: Can't just delete MIME type registration for .webmanifest file. Closes w3c#669.
Note: Can't just delete MIME type registration for .webmanifest file. Closes w3c#669.
Discussed with @marcoscaceres and @dominickng : the new "document is installable" logic gives us a path forward on this:
|
As discussed in #668, the current default for
start_url
is the document URL (the page that referred the user agent to this manifest). That isn't very satisfactory, for a few reasons:Furthermore, Google Chrome does not let the app be installed if
start_url
is omitted (in violation of the spec).In order to make the interpretation of the manifest a function of only the manifest (and not dynamic factors like "what page the user was on when they installed this app"), the
start_url
default needs to change, to either:start_url
mandatory, or/
(the root of the site), or.
(the containing directory of the manifest). I think this makes the most sense, because then a manifest "/myapp/manifest.json" has a default start URL of "/myapp/" and a default scope of "/myapp/".While
.
makes the most sense, it breaks forwards-compatibility with current implementations (new manifests taking advantage of the new default will not work in current-generation user agents). Making it mandatory seems the most compatible option.However, I noticed this line in the spec:
So that makes it a little awkward to make
start_url
mandatory, if technically it is a "hint" which the UA can ignore. I still think it makes sense for it to be mandatory that the site supply a "default"start_url
, even if the user or user agent can override it.The text was updated successfully, but these errors were encountered: