Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spec Metadata Lists Incorrect Values for Chrome #939

Closed
jpmedley opened this issue Nov 17, 2020 · 7 comments
Closed

Spec Metadata Lists Incorrect Values for Chrome #939

jpmedley opened this issue Nov 17, 2020 · 7 comments
Labels
Defer Until after REC question

Comments

@jpmedley
Copy link

The Browser Support heading in the spec manifest shows support in Chrome as 89. If I hover over the label it expands to show Chrome support in 86 through 89. (I'm not sure why I thought to hover. There's no affordance suggesting that I should do that.)

Chrome has actually supported web app manifest since 39. There is a similar problem with the Chrome Android label.

Also Chrome 89 does not even exist yet. The current dev channel is Chrome 88.

image

@christianliebel
Copy link
Member

Hi Joe! From my understanding, the browser support section shows data from caniuse.com, where the Chrome support data appears to be correct: https://caniuse.com/web-app-manifest

The caniuse integration in ReSpec retrieves the four latest versions of a browser (https://github.com/w3c/respec/blob/develop/src/core/caniuse.js#L108), showing the latest one on the label, and hiding the previous three in the submenu. This includes prerelease versions. My installation of Chrome Canary is on version 89 already, so it seems as if M89 is already in preview.

It may make sense to show the latest released version of the browser on the label and all supported versions in the hover menu. That however would be a feature request for ReSpec.

.cc @sidvishnoi @marcoscaceres

@jpmedley
Copy link
Author

I'll open a ticket on respec. In the meantime, I'd suggest removing it completely because it's showing incorrect data.

@sidvishnoi
Copy link
Member

It may make sense to show the latest released version of the browser on the label and all supported versions in the hover menu.

The default number of browsers can be adjusted in respecConfig (https://respec.org/docs/#caniuse):

var respecConfig = {
  caniuse: {
    feature: "web-app-manifest",
    versions: 10,
  },
};

Though, showing too many versions might become too clumsy. I'll try to see if we can group versions like caniuse.com does.

@sidvishnoi
Copy link
Member

Also, I'm not sure if it'll add much value as we do not intend to copy the caniuse table into ReSpec/spec. This is what the "More info" link is for.

@jpmedley
Copy link
Author

jpmedley commented Nov 18, 2020 via email

@marcoscaceres
Copy link
Member

I agree that what it shows is not great. sidvishnoi/respec-caniuse-route#8 would solve the problem via the grouping.

I guess the best thing to do here right now would be to just set "versions" to 1. That disables the hover behavior and just shows the latest supported version.

@jpmedley, would that be suitable?

@christianliebel christianliebel added the Defer Until after REC label Mar 4, 2021
@christianliebel
Copy link
Member

I am closing this as the browser support section now links to caniuse.com.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Defer Until after REC question
Projects
None yet
Development

No branches or pull requests

4 participants