Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding file_handlers and launch consumer #1005

Closed
wants to merge 31 commits into from
Closed
Changes from 1 commit
Commits
Show all changes
31 commits
Select commit Hold shift + click to select a range
e8876d1
Initial skeleton of file handlers
dmurph Sep 8, 2021
c192f5b
Filling out skeleton a bit more
dmurph Sep 13, 2021
5d90d95
cleanup
dmurph Sep 13, 2021
0c776d2
Apply suggestions from code review
dmurph Sep 16, 2021
c4bdc45
responding to comments
dmurph Sep 16, 2021
e8fbf0f
added section for launching file handler
dmurph Sep 16, 2021
de162c0
better concepts?
dmurph Sep 17, 2021
0cb99c7
comments, parsing accept, and trying to cite MIMETYPE
dmurph Sep 20, 2021
6751b21
forgot one comment
dmurph Sep 20, 2021
da157af
Moved execution to new section, and finalized
dmurph Sep 24, 2021
d964c0d
comments
dmurph Sep 29, 2021
3e1451b
added file handle 'read' clarification
dmurph Sep 29, 2021
d089331
comments from Jake
dmurph Oct 6, 2021
76082ec
Make some refinements across the board.
Feb 11, 2022
1a35bdd
Merge branch 'w3c:gh-pages' into file-handling
evanstade Feb 11, 2022
f64fc16
Add section for launch queue and launch params
loubrett Feb 17, 2022
f7b32e9
Add section for launch queue and launch params
loubrett Feb 17, 2022
1da420d
Add algorithm for matching file handler item.
Feb 26, 2022
4903da0
Address comments
loubrett Mar 1, 2022
63a06b0
dmurph review
Mar 1, 2022
d1916e2
Comments
loubrett Mar 2, 2022
603b58f
Update index.html
evanstade Mar 2, 2022
dea41ae
Merge pull request #1 from loubrett/file-handling
evanstade Mar 2, 2022
57c0677
Merge branch 'file-handling' of https://github.com/dmurph/manifest in…
Mar 2, 2022
d2b6298
Merge and tidy up
Mar 2, 2022
9af6b9a
Merge pull request #2 from evanstade/file-handling
evanstade Mar 2, 2022
4832e53
update algo for multilaunch
Mar 15, 2022
ed5930f
.
Mar 15, 2022
8061a4e
Edits for clarity
Mar 15, 2022
f9b42fd
Edits for clarity
Mar 15, 2022
0d29fd1
Changes subsequent to Marcos review.
Mar 30, 2022
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
46 changes: 20 additions & 26 deletions index.html
Original file line number Diff line number Diff line change
Expand Up @@ -1022,6 +1022,24 @@ <h3>
represents URLs within the app that handles launches of given [=file
dmurph marked this conversation as resolved.
Show resolved Hide resolved
types=].
</p>
<p>
A <dfn>file type</dfn> refers to file that has a [=mime type=] and/or
dmurph marked this conversation as resolved.
Show resolved Hide resolved
ends with a [=file extension=]. A <dfn>file extension</dfn> is a
string that start with a "." and only contains [=valid suffix code
points=]. A <dfn>valid suffix code point</dfn> is a [=code point=]
that is [=ASCII alphanumeric=], U+002B (+), or U+002E (.).
Additionally, [=file extensions=] are are limited to a length of 16
code points.
</p>
<aside class="note">
<p>
Note: These code points were chosen to support most pre-existing
file formats. The vast majority of file extensions are purely
alphanumeric, but compound extensions (such as .tar.gz) and
extensions such as .c++ for C++ source code are also fairly common,
hence the inclusion of + and . as allowed code points.
</p>
</aside>
<p>
How file handlers are registered and disambiguated is at the
discretion of the operating system.
Expand Down Expand Up @@ -1962,8 +1980,8 @@ <h3>
"file handler">action</dfn></code> member is a <a>string</a> that
represents a relative URL of the [=manifest/start_url=] origin that
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should probably be resolved relative to the manifest's URL instead (like other URLs in the manifest).

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for catching, done.

is [=manifest/within scope=] of a [=Document/processed manifest=].
This URL will be navigated to in the steps to [=execute a file handler
launch=].
This URL will be navigated to in the steps to [=execute a file
handler launch=].
</p>
</section>
<section>
Expand Down Expand Up @@ -2013,30 +2031,6 @@ <h3>
be replaced by the user agent for privacy & security reasons.
</p>
</section>
<section>
<h2>
Concepts
</h2>
<p>
A <dfn>valid suffix code point</dfn> is a [=code point=] that is
[=ASCII alphanumeric=], U+002B (+), or U+002E (.).
</p>
<aside class="note">
<p>
Note: These code points were chosen to support most pre-existing
file formats. The vast majority of file extensions are purely
alphanumeric, but compound extensions (such as .tar.gz) and
extensions such as .c++ for C++ source code are also fairly common,
hence the inclusion of + and . as allowed code points.
</p>
</aside>
<p>
A <dfn>file type</dfn> refers to file that has a [=mime type=] and/or
ends with an extension. Extensions have to be strings that start with
a "." and only contain [=valid suffix code points=]. Additionally
extensions are limited to a length of 16 code points.
</p>
</section>
<section>
<h2>
Processing file handler items
Expand Down