Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ran tidy #1067

Merged
merged 1 commit into from Jan 23, 2023
Merged

Ran tidy #1067

merged 1 commit into from Jan 23, 2023

Conversation

mgiuca
Copy link
Collaborator

@mgiuca mgiuca commented Jan 20, 2023

This change (choose at least one, delete ones that don't apply):

  • Is a "chore" (metadata, formatting, fixing warnings, etc).

Commit message:

Ran tidy.

Person merging, please make sure that commits are squashed with one of the following as a commit message prefix:

  • chore:

Preview | Diff

Copy link
Member

@marcoscaceres marcoscaceres left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: we have bot that runs tidy after merge, but it's totally also ok to run tidy manually if needed.

@mgiuca
Copy link
Collaborator Author

mgiuca commented Jan 23, 2023

Note: we have bot that runs tidy after merge, but it's totally also ok to run tidy manually if needed.

Do you mean after every merge? Or some larger "merge" milestone?

It doesn't appear to have been working (or my tidy settings are different to the bot? I'm using the command-line in CONTRIBUTING), seeing as how when I run tidy I get this diff.

It was getting difficult to write PRs for Manifest since every time I would run tidy, it would generate this huge diff.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants