Add background_color member (close #394). #396
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| The <dfn id= | ||
| "member-background_color"><code>background_color</code></dfn> member | ||
| describes the expected background color of the web application. It | ||
| will repeat what is already available in the application stylesheet |
There was a problem hiding this comment.
"will repeat" sounds like the UA should do something. This might confused devs. Just say "repeats".
|
r+ from me, bar the nits :) Thanks @mounirlamouri for drafting the text! |
marcoscaceres
changed the title
mounirlamouri
force-pushed
the
background_color
branch
from
a857771
to
d96f6ae
Compare
|
Thanks for the review! |
mounirlamouri
added a commit
that referenced
this pull request
Aug 15, 2015
Add background_color member (close #394).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@kenchris @marcoscaceres please take a look.