Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for 'serviceworkers' member #507

Merged
merged 9 commits into from
Jan 17, 2017
Merged

Add support for 'serviceworkers' member #507

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
9e5567a
Add support for 'serviceworker' member
kenchris Oct 20, 2016
4a5f762
Review fixes after Marcos' comments
kenchris Dec 12, 2016
e97ab3e
Add Service Worker registration, with some help from Jungkee
kenchris Dec 13, 2016
2524071
Add support for 'type' and 'use_cache' when registering a service worker
kenchris Dec 13, 2016
3df8f7a
A few changes based on feedback by Jungkee
kenchris Dec 14, 2016
5d37374
Clean up spec text a bit
kenchris Dec 15, 2016
5c867ad
Add client to Start Register
kenchris Dec 15, 2016
4fc48b1
Fix two return values pointed out by Jungkee
kenchris Dec 15, 2016
77bdd10
Fix comments from Marcos
kenchris Dec 28, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
10 changes: 7 additions & 3 deletions index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -349,13 +349,17 @@ <h3>
<li>If <a>obtaining the manifest</a> succeeds, and the result of running the
<a>steps for processing the serviceworker member</a> with <a>manifest</a>
returns a valid <var>registration</var>, a user agent can at this point
<ul>
<ol>
<li>Let <var>client</var> be the <a>top-level browsing context</a>'
<code>Document</code>'s
<a href="https://html.spec.whatwg.org/multipage/webappapis.html#relevant-settings-object">
relevant settings object</a>, or <code>null</code> if unavailable.
<li>Invoke <a>Start Register</a> with <var>scope</var> and <var>src</var>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

q: should this be "Let registration be the result of Start Registration".

The way this is spec'ed is a bit strange - I was expecting some kind of flow with the resulting promise... but it all seems to magically result in a registration.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure how to best solve this. Maybe you could solve in a follow up?

members of the <var>registration</var>, a new <var>promise</var>,
null, <a>manifest URL</a>, plus the <var>type</var> and <var>use_cache</var>
<var>client</var>, <a>manifest URL</a>, plus the <var>type</var> and <var>use_cache</var>
members of the <var>registration</var>,
</li>
</ul>
</ol>
in which case the state of the settled <var>promise</var> determine whether the
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: determines

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

<a>installation succeeded</a> or not.
</li>
Expand Down